Skip to content

{UpdateExtCommandTree} Support aaz commands #4968

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
kairu-ms merged 1 commit into from
Jun 10, 2022
Merged

{UpdateExtCommandTree} Support aaz commands #4968

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 1 addition & 2 deletions scripts/ci/update_ext_cmd_tree.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,8 +44,7 @@ def update_cmd_tree(ext_name):
az_cli.invocation = invoker

sys.path.append(ext_dir)
extension_command_table, _ = _load_extension_command_loader(invoker.commands_loader,
"", ext_mod)
extension_command_table, _ = _load_extension_command_loader(invoker.commands_loader, None, ext_mod)
Copy link
Copy Markdown
Contributor Author

@kairu-ms kairu-ms Jun 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"" empty string will cause cut when loading command table for aaz commands. Replace it by None for fully load.

Copy link
Copy Markdown
Member

@jiasli jiasli Jun 10, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you give some more info? I can't really understand the context. 😅


EXT_CMD_TREE_TO_UPLOAD = Session()
EXT_CMD_TREE_TO_UPLOAD.load(os.path.expanduser(os.path.join('~', '.azure', file_name)))
Expand Down