Skip to content

fixing OS partition detection#5507

Merged
zhoxing-ms merged 3 commits into
Azure:mainfrom
jofrance:master
Nov 15, 2022
Merged

fixing OS partition detection#5507
zhoxing-ms merged 3 commits into
Azure:mainfrom
jofrance:master

Conversation

@jofrance
Copy link
Copy Markdown
Contributor

@jofrance jofrance commented Nov 1, 2022


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
The precondition is to put your code inside this repository and upgrade the version in the pull request but do not modify src/index.json.

@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Nov 1, 2022
@ghost
Copy link
Copy Markdown

ghost commented Nov 1, 2022

Thank you for your contribution jofrance! We will review the pull request and get back to you soon.

@jofrance
Copy link
Copy Markdown
Contributor Author

jofrance commented Nov 1, 2022

#sing-off

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Nov 2, 2022

vm repair

@haagha
Copy link
Copy Markdown
Member

haagha commented Nov 2, 2022

@zhoxing-ms I am not added as part of the automatic reviewers despite me being code-owner for this repo.

https://github.com/Azure/azure-cli-extensions/blob/main/.github/CODEOWNERS#L63

@zhoxing-ms
Copy link
Copy Markdown
Contributor

zhoxing-ms commented Nov 10, 2022

@jofrance Could you please add description in the history notes for this change?

@zhoxing-ms
Copy link
Copy Markdown
Contributor

I am not added as part of the automatic reviewers despite me being code-owner for this repo.

@haagha Please submit a PR to apply for code owner, and I will approve and merge it for you

@jofrance
Copy link
Copy Markdown
Contributor Author

fixing OS partition detection for RHEL ADE encrypted VMS and changing version to 0.4.9

@zhoxing-ms
Copy link
Copy Markdown
Contributor

@jofrance It is recommended to write this version change into the HISTORY.rst

@jofrance
Copy link
Copy Markdown
Contributor Author

jofrance commented Nov 14, 2022 via email

@zhoxing-ms zhoxing-ms merged commit 808b1f2 into Azure:main Nov 15, 2022
@azclibot
Copy link
Copy Markdown
Collaborator

[Release] Update index.json for extension [ vm-repair ] : https://dev.azure.com/azclitools/internal/_build/results?buildId=14833&view=results

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants