[containerapp] az containerapp connected-env: Sopport dapr-component/storage/certificate#6727
Conversation
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp connected-env certificate | sub group containerapp connected-env certificate added |
||
| containerapp connected-env dapr-component | sub group containerapp connected-env dapr-component added |
||
| containerapp connected-env storage | sub group containerapp connected-env storage added |
|
Hi @Greedygre, |
microsoft-github-policy-service
Bot
requested review from
wangzelin007,
yanzhudd,
yonzhan and
zhoxing-ms
|
containerapp |
microsoft-github-policy-service
Bot
requested review from
JennyLawrance,
Juliehzl,
chinadragon0515,
ebencarek,
howang-ms,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto and
vturecek
…com/Greedygre/azure-cli-extensions into xinyu/move_dapr_storage_certificate
Greedygre
changed the title
az containerapp connected-env: Sopport dapr-component/storage/certificate
|
Hi @zhoxing-ms |
| c.argument('dapr_app_id', help="The Dapr app ID.") | ||
| c.argument('dapr_app_port', help="The port of your app.") | ||
| c.argument('dapr_app_protocol', help="Tell Dapr which protocol your application is using. Allowed values: grpc, http.") |
There was a problem hiding this comment.
May I ask if these parameters are not available anymore after this change? will this change make a breaking change for customers?
There was a problem hiding this comment.
These parameters are not supported before, they are unused.
So it will not be a breaking change.
| c.argument('prompt', options_list=['--show-prompt'], action='store_true', help='Show prompt to upload an existing certificate.') | ||
|
|
||
| with self.argument_context('containerapp connected-env certificate list') as c: | ||
| c.argument('name', id_part=None) |
There was a problem hiding this comment.
Please add help message for this parameter.
There was a problem hiding this comment.
The name's help currently come from argument group containerapp connected-env, no need to add help for name again in sub command group.
But argument name in sub command has setting id_part=None, which is different with containerapp connected-env.
| @ResourceGroupPreparer(location=TEST_LOCATION, random_name_length=15) | ||
| @ConnectedClusterPreparer(location=TEST_LOCATION) | ||
| def test_containerappjob_preview_environment_type(self, resource_group, infra_cluster, connected_cluster_name): | ||
| self.cmd('configure --defaults location={}'.format(TEST_LOCATION)) |
There was a problem hiding this comment.
May I ask why need to config the default value of location intead of inputting manually?
There was a problem hiding this comment.
That is because we need all test resources created in same region, and we have vendor to run tests in all regions one by one.
In core, we have this PR to avoid impact others' services: {containerapp} add random config directory for test by Greedygre · Pull Request #27382 · Azure/azure-cli (github.com).
There was a problem hiding this comment.
Will add random config directory in next PR in extension, consisting with core.
6 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az containerapp connected-env certificate delete/list/upload
az containerapp connected-env dapr-component list/remove/set/show
az containerapp connected-env storage list/remove/set/show
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.