Skip to content

Various text improvements for virtual-network-manager#6788

Closed
jago2136 wants to merge 4 commits into
Azure:mainfrom
jago2136:jaredgorthy/AvNM-improvements
Closed

Various text improvements for virtual-network-manager#6788
jago2136 wants to merge 4 commits into
Azure:mainfrom
jago2136:jaredgorthy/AvNM-improvements

Conversation

@jago2136
Copy link
Copy Markdown
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally?

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Sep 20, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @jago2136,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @jago2136,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Sep 20, 2023

Thank you for your contribution! We will review the pull request and get back to you soon.

@calvinhzy
Copy link
Copy Markdown
Member

Hi @jago2136, thank you for raising these changes, since we are using CodeGen to generate this final code, I will raise another PR with the same changes with CodeGen so the internal model https://github.com/Azure/aaz has these changes too.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot Network

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants