[containerapp] az containerapp job create: Add default values for properties#6789
Merged
Conversation
|
Hi @p-bouchon, |
|
Hi @p-bouchon, |
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| containerapp job create | cmd containerapp job create update parameter max_executions: added property default=100 |
||
| containerapp job create | cmd containerapp job create update parameter parallelism: added property default=1 |
||
| containerapp job create | cmd containerapp job create update parameter polling_interval: added property default=30 |
||
| containerapp job create | cmd containerapp job create update parameter replica_completion_count: added property default=1 |
||
| containerapp job create | cmd containerapp job create update parameter replica_timeout: added property default=1800 |
microsoft-github-policy-service
Bot
requested review from
wangzelin007,
yanzhudd,
yonzhan and
zhoxing-ms
Collaborator
|
Thank you for your contribution! We will review the pull request and get back to you soon. |
microsoft-github-policy-service
Bot
requested review from
Greedygre,
JennyLawrance,
Juliehzl,
chinadragon0515,
ebencarek,
howang-ms,
jijohn14,
jsntcy,
pagariyaalok,
ruslany,
sanchitmehta,
torosent,
vinisoto and
vturecek
p-bouchon
changed the title
vinisoto
approved these changes
Sep 25, 2023
yanzhudd
reviewed
Sep 26, 2023
Contributor
|
If you want to release a new version of the extension, please change the version in setup.py as well. |
added 2 commits
September 26, 2023 09:59
Contributor
|
Recommend PR title: |
p-bouchon
changed the title
Greedygre
reviewed
Sep 26, 2023
Greedygre
approved these changes
Oct 6, 2023
Greedygre
reviewed
Oct 6, 2023
Contributor
Please do not paste the internal link. |
Greedygre
reviewed
Oct 8, 2023
Greedygre
reviewed
Oct 11, 2023
Comment on lines
+498
to
+500
| if self.get_argument_trigger_type() is None: | ||
| raise RequiredArgumentMissingError('Usage error: --trigger-type is required') | ||
| return super().validate_arguments() |
Contributor
There was a problem hiding this comment.
Suggested change
| if self.get_argument_trigger_type() is None: | |
| raise RequiredArgumentMissingError('Usage error: --trigger-type is required') | |
| return super().validate_arguments() | |
| super().validate_arguments() | |
| if self.get_argument_yaml() is None: | |
| if self.get_argument_trigger_type() is None: | |
| raise RequiredArgumentMissingError('Usage error: --trigger-type is required') |
Contributor
There was a problem hiding this comment.
With --yaml, the --trigger-type is not required, right?
Greedygre
approved these changes
Oct 11, 2023
Contributor
|
Hi @yanzhudd @zhoxing-ms |
yanzhudd
reviewed
Oct 12, 2023
Comment on lines
+501
to
+507
| c.argument('replica_completion_count', type=int, options_list=['--replica-completion-count', '--rcc'], help='Number of replicas that need to complete successfully for execution to succeed', default=1) | ||
| c.argument('replica_retry_limit', type=int, help='Maximum number of retries before the replica fails. Default: 0.', default=0) | ||
| c.argument('replica_timeout', type=int, help='Maximum number of seconds a replica can execute', default=1800) | ||
| c.argument('parallelism', type=int, help='Maximum number of replicas to run per execution', default=1) | ||
| c.argument('min_executions', type=int, help="Minimum number of job executions that are created for a trigger. Default: 0.", default=0) | ||
| c.argument('max_executions', type=int, help="Maximum number of job executions that are created for a trigger", default=100) | ||
| c.argument('polling_interval', type=int, help="Interval to check each event source in seconds.", default=30) |
Contributor
There was a problem hiding this comment.
May I ask if these params are new added and have been tested?
Contributor
There was a problem hiding this comment.
Yes, Tested in new added test test_containerapp_manualjob_defaults_e2e.
yanzhudd
reviewed
Oct 12, 2023
yanzhudd
approved these changes
Oct 12, 2023
scrappywyrm
pushed a commit
to scrappywyrm/azure-cli-extensions
that referenced
this pull request
Oct 16, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
'az containerapp job create'
General Guidelines
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally?For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.