Skip to content

{containerapp} Improve tests: Use same name foo for compose tests#6853

Merged
yanzhudd merged 1 commit into
Azure:mainfrom
Greedygre:xinyu/containerapp_make_compose_test_stable
Oct 11, 2023
Merged

{containerapp} Improve tests: Use same name foo for compose tests#6853
yanzhudd merged 1 commit into
Azure:mainfrom
Greedygre:xinyu/containerapp_make_compose_test_stable

Conversation

@Greedygre
Copy link
Copy Markdown
Contributor

@Greedygre Greedygre commented Oct 11, 2023

All Containerapp Compose test cases have @serial_test() to mark test run serial.
Use following command run test cases which have been mark to serial.
azdev test azext_containerapp.containerapp --no-exitfirst --series -a '-m=serial'
I found when using different service name in compose file for compose tests, and then executed in parallel, will occur error (only occur this error with azdev test in parallel). So need to revert test cases back to use same name foo.


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Oct 11, 2023

️✔️Azure CLI Extensions Breaking Change Test
️✔️Non Breaking Changes

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @Greedygre,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Oct 11, 2023

containerapp

@Greedygre
Copy link
Copy Markdown
Contributor Author

Hi @yanzhudd
Could you please help to review this PR? Thanks.

@yanzhudd yanzhudd merged commit e3fd61f into Azure:main Oct 11, 2023
scrappywyrm pushed a commit to scrappywyrm/azure-cli-extensions that referenced this pull request Oct 16, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants