Skip to content

Enable NFS Azure file Storage for managed environment#7155

Merged
wangzelin007 merged 3 commits into
Azure:mainfrom
LaylaLiu-gmail:user/layliu/Enablenfsazurefile
Feb 4, 2024
Merged

Enable NFS Azure file Storage for managed environment#7155
wangzelin007 merged 3 commits into
Azure:mainfrom
LaylaLiu-gmail:user/layliu/Enablenfsazurefile

Conversation

@LaylaLiu-gmail
Copy link
Copy Markdown
Contributor


This checklist is used to make sure that common guidelines for a pull request are followed.

Related command

az containerapp env storage set

General Guidelines

  • Have you run azdev style <YOUR_EXT> locally? (pip install azdev required)
  • Have you run python scripts/ci/test_index.py -q locally? (pip install wheel==0.30.0 required)

For new extensions:

About Extension Publish

There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update src/index.json automatically.
You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify src/index.json.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

azure-client-tools-bot-prd Bot commented Jan 5, 2024

⚠️Azure CLI Extensions Breaking Change Test
⚠️containerapp
rule cmd_name rule_message suggest_message
⚠️ 1006 - ParaAdd containerapp env storage set cmd containerapp env storage set added parameter server
⚠️ 1006 - ParaAdd containerapp env storage set cmd containerapp env storage set added parameter storage_type
⚠️ 1009 - ParaPropRemove containerapp env storage set cmd containerapp env storage set update parameter access_mode: removed property required=True
⚠️ 1009 - ParaPropRemove containerapp env storage set cmd containerapp env storage set update parameter azure_file_account_key: removed property required=True
⚠️ 1009 - ParaPropRemove containerapp env storage set cmd containerapp env storage set update parameter azure_file_account_name: removed property required=True
⚠️ 1009 - ParaPropRemove containerapp env storage set cmd containerapp env storage set update parameter azure_file_share_name: removed property required=True

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @LaylaLiu-gmail,
Since the current milestone time is less than 7 days, this pr will be reviewed in the next milestone.

@azure-client-tools-bot-prd
Copy link
Copy Markdown

Hi @LaylaLiu-gmail,
Please write the description of changes which can be perceived by customers into HISTORY.rst.
If you want to release a new extension version, please update the version in setup.py as well.

@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Jan 5, 2024

Thank you for your contribution! We will review the pull request and get back to you soon.

Comment thread src/containerapp/HISTORY.rst Outdated
Comment thread src/containerapp/azext_containerapp/_clients.py Outdated
Comment thread src/containerapp/azext_containerapp/_help.py Outdated
Comment thread src/containerapp/azext_containerapp/_params.py Outdated
Comment thread src/containerapp/azext_containerapp/_params.py Outdated
Comment thread src/containerapp/azext_containerapp/containerapp_env_storage_decorator.py Outdated
@Greedygre Greedygre force-pushed the user/layliu/Enablenfsazurefile branch from 6857e28 to 80ab995 Compare January 16, 2024 06:27
@Greedygre Greedygre force-pushed the user/layliu/Enablenfsazurefile branch from f1b73be to 9146af8 Compare January 25, 2024 07:40
@LaylaLiu-gmail LaylaLiu-gmail force-pushed the user/layliu/Enablenfsazurefile branch 2 times, most recently from b595eb8 to 49bd999 Compare February 2, 2024 08:15
@LaylaLiu-gmail LaylaLiu-gmail force-pushed the user/layliu/Enablenfsazurefile branch from 49bd999 to 1af7235 Compare February 2, 2024 08:18
Comment thread src/containerapp/azext_containerapp/containerapp_env_storage_decorator.py Outdated
Comment thread src/containerapp/azext_containerapp/containerapp_env_storage_decorator.py Outdated
Comment thread src/containerapp/azext_containerapp/containerapp_env_storage_decorator.py Outdated
Comment thread src/containerapp/azext_containerapp/containerapp_env_storage_decorator.py Outdated
Comment thread src/containerapp/azext_containerapp/containerapp_env_storage_decorator.py Outdated
@wangzelin007 wangzelin007 merged commit c204422 into Azure:main Feb 4, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot ContainerApp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

7 participants