{AKS} Support reset default value for loadbalancer profile and natgateway profile - #7230
Conversation
️✔️Azure CLI Extensions Breaking Change Test
|
|
Hi Fan Shangxiang (@MartinForReal), |
|
Hi Fan Shangxiang (@MartinForReal), |
|
AKS |
There was a problem hiding this comment.
lgtm
Queued live test to validate the change, test passed!
| if self.context.get_nat_gateway_managed_outbound_ip_count() is not None: | ||
| network_profile.nat_gateway_profile = create_nat_gateway_profile( | ||
| self.context.get_nat_gateway_managed_outbound_ip_count(), | ||
| self.context.get_nat_gateway_idle_timeout(), | ||
| models=self.models.nat_gateway_models, | ||
| ) | ||
|
|
There was a problem hiding this comment.
Perhaps this part can be omitted as it's part of the create process, even if setting it to 0 is ignored, the default value will be backfilled to 0?
There was a problem hiding this comment.
The default value is 1
|
Requeued live test
|
The test passed. |
5 participants
This checklist is used to make sure that common guidelines for a pull request are followed.
Related command
az aks update --load-balancer-outbound-ports 0General Guidelines
related: #27071
azdev style <YOUR_EXT>locally? (pip install azdevrequired)python scripts/ci/test_index.py -qlocally? (pip install wheel==0.30.0required)For new extensions:
About Extension Publish
There is a pipeline to automatically build, upload and publish extension wheels.
Once your pull request is merged into main branch, a new pull request will be created to update
src/index.jsonautomatically.You only need to update the version information in file setup.py and historical information in file HISTORY.rst in your PR but do not modify
src/index.json.