{Monitor} Move antlr4-python3-runtime to src/azure-cli/setup.py - #12917
Conversation
| packages=find_packages(exclude=["*.tests", "*.tests.*", "tests.*", "tests"]), | ||
| install_requires=DEPENDENCIES, | ||
| extras_require={ | ||
| ":python_version<'3.0'": ['antlr4-python2-runtime'] |
There was a problem hiding this comment.
We have dropped Python 2. We can safely remove this dependency. #11363
| ] | ||
|
|
||
| DEPENDENCIES = [ | ||
| 'antlr4-python3-runtime~=4.7.2', |
There was a problem hiding this comment.
I'm not sure. Is it the correct way to fix this issue? Feng Zhou (@fengzhou-msft) Since python2 and python3 share the same namespace.
There was a problem hiding this comment.
We do not support python 2 now, this is fine.
There was a problem hiding this comment.
Do you have any code that may have different handlings for py2 and py3 with this antlr4 dependency? You may also clean that code if yes.
There was a problem hiding this comment.
no. They share same signature to us.
| packages=find_packages(exclude=["*.tests", "*.tests.*", "tests.*", "tests"]), | ||
| install_requires=DEPENDENCIES, | ||
| extras_require={ | ||
| ":python_version<'3.0'": ['antlr4-python2-runtime'] |
There was a problem hiding this comment.
maybe something like ":python_version<'3.0'": ['antlr4-python2-runtime'==4.7.2]?
There was a problem hiding this comment.
Just delete this line.
|
add to S168 |
Myron (mmyyrroonn)
changed the title
4 participants
antlr4 is used in monitor. We use 4.7.2 antlr4 tool to generate some codes in monitor. We still need a antlr4 runtime. But we didn't define it as a requirement in azure-cli before. In azure-cli-core, the version is not locked and the new version is 4.8.0. It would cause warning if two versions are not same.
Fix #12892
Description of PR (Mandatory)
(Why this PR? What is changed? What is the effect? etc. A high-quality description can accelerate the review process)
Testing Guide
(Example commands with explanations)
History Notes:
(Fill in the following template if multiple notes are needed, otherwise PR title will be used for history note.)
[Component Name 1] (BREAKING CHANGE:) (az command:) make some customer-facing change.
[Component Name 2] (BREAKING CHANGE:) (az command:) make some customer-facing change.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.