{Util} Add util module for version and rest - #13783
Merged
Merged
Conversation
jiasli
requested review from
Juliehzl,
haroldrandom,
qianwens and
zhoxing-ms
as code owners
June 2, 2020 05:16
jiasli
changed the title
Collaborator
|
add to S171 |
# Conflicts: # src/azure-cli/azure/cli/command_modules/resource/_help.py
zhoxing-ms
reviewed
Jun 3, 2020
| # Licensed under the MIT License. See License.txt in the project root for license information. | ||
| # -------------------------------------------------------------------------------------------- | ||
|
|
||
| from __future__ import print_function |
Contributor
There was a problem hiding this comment.
We don't support Python 2.0+ anymore, right?
Do we still need from __future__ import print_function? print-as-a-function
Contributor
Author
There was a problem hiding this comment.
Nice catch! I simply migrated the code from src/azure-cli/azure/cli/command_modules/resource/custom.py. Removed.
zhoxing-ms
self-requested a review
June 5, 2020 05:32
Juliehzl
reviewed
Jun 5, 2020
| except ValueError: | ||
| logger.warning('Not a json response, outputting to stdout. For binary data ' | ||
| 'suggest use "--output-file" to write to a file') | ||
| print(r.text) |
Contributor
There was a problem hiding this comment.
Prefer to not use print() according to command guideline.
Juliehzl
approved these changes
Jun 5, 2020
haroldrandom
approved these changes
Jun 5, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Peel off
az versionandaz restfromresourcemodule. A new moduleutilis created. Thus they don't carry the burden ofazure-mgmt-resourceinitialization when running these commandsresourcecommand module when developing these commandsThis makes running and developing
az versionandaz restsignificantly faster.Testing Guide