[Compute] Fix a vmss update, disk attach/detach, extension set/delete issue - #14992
Merged
Conversation
Feiyue Yu (qwordy)
requested a review
from Xiaojian Xu (arrownj)
as a code owner
August 31, 2020 12:44
| g.custom_command('start', 'start_vmss', supports_no_wait=True) | ||
| g.custom_command('stop', 'stop_vmss', supports_no_wait=True, validator=process_vm_vmss_stop) | ||
| g.generic_update_command('update', getter_name='get_vmss', setter_name='update_vmss', supports_no_wait=True, command_type=compute_custom, validator=validate_vmss_update_namespace) | ||
| g.generic_update_command('update', getter_name='get_vmss_modified', setter_name='update_vmss', supports_no_wait=True, command_type=compute_custom, validator=validate_vmss_update_namespace) |
Contributor
There was a problem hiding this comment.
This is a very special case, it's better to add a standalone test for it.
Contributor
There was a problem hiding this comment.
Considering it needs to update the permission of user in a subscription, I'm OK to skip the test. Let's make sure the test is done in local.
Member
Author
There was a problem hiding this comment.
I test it manually
Member
There was a problem hiding this comment.
long term we need to switch to patch mode to completely resolve the issue. I'll file an issue to track it. While that need service team confirmation firstly.
Xiaojian Xu (arrownj)
approved these changes
Sep 2, 2020
Feiyue Yu (qwordy)
changed the title
Member
Author
|
I can't merge it now. It breaks a successfully test case. Let's wait for VMSS service team to support not setting image reference. |
Member
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Member
|
service side ready, and tested the change works. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
2 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Resolve #14924
Resolve #15058
Support partial update of vmss to avoid unnecessary permission check.
How to try it. https://github.com/Azure/azure-cli/blob/dev/doc/try_new_features_before_release.md
Testing Guide
History Notes
[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.