[Core] Add 2020-09-01-hybrid API profile for AzureStack - #15096
Merged
Conversation
bganapa
changed the title
Collaborator
|
DNM |
abbhar
marked this pull request as draft
September 9, 2020 03:00
Jiashuo Li (jiasli)
approved these changes
Sep 11, 2020
abbhar
marked this pull request as ready for review
September 28, 2020 17:23
abbhar
requested review from
Bin Ma (bim-msft),
Paymaun (digimaun) and
Yunge Zhu (yungezz)
as code owners
September 28, 2020 17:23
abbhar
marked this pull request as draft
September 28, 2020 17:27
abbhar
force-pushed
the
abbhar/profile-2020
branch
2 times, most recently
from
October 14, 2020 02:23
bca0bb9 to
13a0e45
Compare
abbhar
force-pushed
the
abbhar/profile-2020
branch
from
December 1, 2020 19:02
e4d76aa to
187dc3c
Compare
abbhar
changed the title
Zunli Hu (Juliehzl)
approved these changes
Dec 2, 2020
Zunli Hu (Juliehzl)
left a comment
Zunli Hu (Juliehzl)
left a comment
Contributor
There was a problem hiding this comment.
LGTM for profile change. Thanks abbhar for adding tests.
Contributor
Zunli Hu (Juliehzl)
changed the title
bganapa
approved these changes
Dec 2, 2020
Member
|
This is good to be merged!. Thanks Zunli Hu (@Juliehzl) for all the inputs in taking this PR to green! |
Feng Zhou (fengzhou-msft)
approved these changes
Dec 3, 2020
Harold Ran (haroldrandom)
approved these changes
Dec 3, 2020
Feiyue Yu (qwordy)
approved these changes
Dec 4, 2020
kai ru (kairu-ms)
approved these changes
Dec 4, 2020
Contributor
|
abbhar May I ask why there are no resource module related tests? |
Jiashuo Li (jiasli)
approved these changes
Dec 4, 2020
Bin Ma (bim-msft)
approved these changes
Dec 4, 2020
|
|
||
| # @ResourceGroupPreparer() | ||
| # @StorageAccountPreparer() | ||
| # def test_renew_account_key(self, resource_group, storage_account): |
Contributor
There was a problem hiding this comment.
it could work with ADDS configured.
If it is supported in Azure Stack, we need to work on reverting the test.
Contributor
Xing Zhou (zhoxing-ms)
approved these changes
Dec 4, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
13 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adding New Api Profile 2020-09-01-hybrid for Azure Stack.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.