Skip to content

[ARM] Fixed the returned data when tagging multiple resources - #15146

Merged
Xing Zhou (zhoxing-ms) merged 1 commit into
Azure:devfrom
zhoxing-ms:fix_tag_multiple_objects
Oct 23, 2020
Merged

[ARM] Fixed the returned data when tagging multiple resources#15146
Xing Zhou (zhoxing-ms) merged 1 commit into
Azure:devfrom
zhoxing-ms:fix_tag_multiple_objects

Conversation

@zhoxing-ms

@zhoxing-ms Xing Zhou (zhoxing-ms) commented Sep 14, 2020

Copy link
Copy Markdown
Contributor

Fix the returned data when tagging multiple resources for 15106
Another problem is that it's not easy to fix it in a short time, so just fix this one for the time being.

Description

The data returned after the resource is tagged is LROPoller, which needs to be wrapped by LongRunningOperation to get the actual result.
When only one resource is tagged, it is handled here link.
However, the process of parsing the results will be omitted when multiple resources are tagged, so add the logic of processing.

Testing Guide

Run az resource tag --tags key=value --ids resource-id1 resource-id2
Before:

[
  {},
  {}
]

After:

[
  {
     "id":"xxx",
      ....
   },
   {
     "id":"xxx",
      ....
   },
]

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@zhoxing-ms Xing Zhou (zhoxing-ms) changed the title [ARM] Fixed the bug that returned the null value when tagging multiple resources [ARM] Fixed the returned data when tagging multiple resources Sep 14, 2020
@yonzhan Yong Zhang (yonzhan) added this to the S176 milestone Sep 14, 2020
@yonzhan

Copy link
Copy Markdown
Collaborator

ARM

@Juliehzl

Copy link
Copy Markdown
Contributor

will this also fix the issue in az resource update?

@zhoxing-ms

Xing Zhou (zhoxing-ms) commented Sep 16, 2020

Copy link
Copy Markdown
Contributor Author

will this also fix the issue in az resource update?

Zunli Hu (@Juliehzl) It only fix the returned data when tagging multiple resources.
Updated the description.

@zhoxing-ms
Xing Zhou (zhoxing-ms) merged commit dc6500f into Azure:dev Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants