Skip to content

[Storage] az storage fs access: Support managing ACLs recursively - #15221

Merged
Yong Zhang (yonzhan) merged 17 commits into
Azure:devfrom
Juliehzl:recursive-acl
Oct 23, 2020
Merged

[Storage] az storage fs access: Support managing ACLs recursively#15221
Yong Zhang (yonzhan) merged 17 commits into
Azure:devfrom
Juliehzl:recursive-acl

Conversation

@Juliehzl

@Juliehzl Zunli Hu (Juliehzl) commented Sep 21, 2020

Copy link
Copy Markdown
Contributor

Description

Set/Update/Remove ACL reclusively on datalake gen2 items with a small amount of requests, for performance improvement. Since currently, set ACL one by one is too slow.

Wait for #15572 merge

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change.
[Component Name 2] az command b: Add some customer-facing feature.


This checklist is used to make sure that common guidelines for a pull request are followed.

@yonzhan

Copy link
Copy Markdown
Collaborator

add to S176

@bim-msft

Copy link
Copy Markdown
Contributor

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

Comment on lines +1691 to +1692
- name: Set the Access Control on a path and sub-paths in Azure Data Lake Storage Gen2 account.
text: az storage fs access set-recursive --acl "default:user:21cd756e-e290-4a26-9547-93e8cc1a8923:rwx" -p dir -f myfilesystem --account-name myadlsaccount --account-key 0000-0000

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The format of the --acl parameter is [scope:][type]:[id]:[permissions], but the location of each part in the acl parameter seems to be a bit confusing. Could we describe it in more detail?
For example:
When permissions are not passed in for acl parameter in the first example, the input value is --acl "default:user:21cd756e-e290-4a26-9547-93e8cc1a8923", but when there are only type and permissions for acl parameter, the input value is --acl "user::r-x"

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actually it is from SDK and it is hard to see more here. But we could provide a link about acl here.

@Juliehzl

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@Juliehzl

Copy link
Copy Markdown
Contributor Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 2 pipeline(s).

@yonzhan
Yong Zhang (yonzhan) merged commit 1210e99 into Azure:dev Oct 23, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Need SDK released Pending for sdk release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants