{Core} Enrich user-agent for az rest - #15472
Merged
Merged
Conversation
Houk (houk-ms)
requested review from
Feng Zhou (fengzhou-msft),
Jiashuo Li (jiasli) and
Yunge Zhu (yungezz)
October 10, 2020 07:17
Houk (houk-ms)
requested review from
Zunli Hu (Juliehzl),
Xiaojian Xu (arrownj),
Harold Ran (haroldrandom),
Yu Chen (jsntcy) and
Myron (mmyyrroonn)
as code owners
October 10, 2020 07:17
Yunge Zhu (yungezz)
approved these changes
Oct 10, 2020
Contributor
Author
|
An exmaple of the az rest UserAgent now: |
Feng Zhou (fengzhou-msft)
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR adds more properties into az rest user-agent, making it align with the python-sdk based requests. This is suggested by our PM Arun so that we can get the python version and os info from the user agents.
Currently, a common user agent from az rest based requests could be
a common user agent from python-sdk based requests could be
The PR adds the following properties into az rest user agents:
These properties won't be added because they are not the dependencies of az rest.
Testing Guide
Run the az rest command, e.g,
Previously, the userAgent is
Now, the userAgent is
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.