{KeyVault} Fix a filter bug while deleting role assignments - #15501
Merged
Conversation
Bin Ma (bim-msft)
requested review from
Feng Zhou (fengzhou-msft) and
Yunge Zhu (yungezz)
as code owners
October 13, 2020 07:06
Collaborator
|
KeyVault |
Contributor
Author
|
/azp run |
|
Azure Pipelines successfully started running 2 pipeline(s). |
Feng Zhou (fengzhou-msft)
approved these changes
Oct 22, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
When running
az keyvault role assignment delete --hsm-name xxx, CLI will delete all assignments under that HSM without any confirmation. This is really user-unfriendly.New behavior: throw an actionable error like this:
RequiredArgumentMissingError: Please specify at least one of these parameters: --name, --scope, --assignee, --assignee-object-id, --role, --idsIn addition, this PR fixed a validation bug within track 2 data-plane clients creation.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.