{Core} Skip positional arguments for failure recommendations - #15570
Merged
Conversation
Houk (houk-ms)
requested review from
Feng Zhou (fengzhou-msft),
Jiashuo Li (jiasli) and
Yunge Zhu (yungezz)
October 19, 2020 03:18
Houk (houk-ms)
requested review from
Zunli Hu (Juliehzl),
Xiaojian Xu (arrownj),
Harold Ran (haroldrandom),
Yu Chen (jsntcy) and
Myron (mmyyrroonn)
as code owners
October 19, 2020 03:18
Contributor
Author
|
Christopher O'Toole (@christopher-o-toole) The original logic in failure recommendation seems to not consider the positional arguments. Do you have any plans to use them in Aladdin Service? |
Closed
Feng Zhou (fengzhou-msft)
approved these changes
Oct 21, 2020
Yunge Zhu (yungezz)
approved these changes
Oct 21, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fix issue #15465,#15591
This PR fixes the positional arguments parsing issue in failure recommendations. The original logic ignored the positional arguments, which would make CLI crash when running a command with positional arguments if that command failed.
Testing Guide
Previously, CLI will crash when running
az acr buildNow, it prints the right error messages