Skip to content

[Packaging] Update Dockerfile base image from Alpine 3.14 to 3.15 - #21079

Merged
jiasli merged 3 commits into
Azure:devfrom
danvy:dev
Jan 25, 2022
Merged

[Packaging] Update Dockerfile base image from Alpine 3.14 to 3.15#21079
jiasli merged 3 commits into
Azure:devfrom
danvy:dev

Conversation

@danvy

@danvy danvy commented Jan 21, 2022

Copy link
Copy Markdown
Contributor

Description

Keep the pace with Alpine and some tools are only available on Alpine 3.15, ie : postgresql14-client

Testing Guide

"docker build -t azure-cli ." to check the build

History Notes

Dockerfile is now based on python Alpine 3.15


This checklist is used to make sure that common guidelines for a pull request are followed.

danvy added 2 commits January 21, 2022 23:37
[Packaging] Dockerfile base image from Alpine 3.14 to 3.15
@ghost ghost added the customer-reported Issues that are reported by GitHub users external to the Azure organization. label Jan 21, 2022
@ghost

ghost commented Jan 21, 2022

Copy link
Copy Markdown

Thank you for your contribution danvy! We will review the pull request and get back to you soon.

@yonzhan

yonzhan commented Jan 22, 2022

Copy link
Copy Markdown
Collaborator

Packaging

@yonzhan
yonzhan requested a review from jiasli January 22, 2022 00:40
@yonzhan yonzhan added this to the Feb 2022 (2022-03-01) milestone Jan 22, 2022
@jiasli

jiasli commented Jan 24, 2022

Copy link
Copy Markdown
Contributor

Ops, the pipeline failed:

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1319619&view=logs&j=a3141784-dfa9-5792-78cc-844daee2d774&t=b2b6de04-64e4-5812-4fff-06c02d19f4c2&l=35

Step 1/15 : ARG PYTHON_VERSION="3.9.6"
Step 2/15 : FROM python:${PYTHON_VERSION}-alpine3.15
manifest for python:3.9.6-alpine3.15 not found: manifest unknown: manifest unknown

We need to use a valid tag from https://hub.docker.com/_/python.

I think we can use 3.10.2-alpine3.15 which will solve #19857 (comment) by the way.

Comment thread Dockerfile Outdated
@jiasli jiasli mentioned this pull request Jan 24, 2022
6 tasks
@danvy

danvy commented Jan 24, 2022

Copy link
Copy Markdown
Contributor Author

Ops, the pipeline failed:

https://dev.azure.com/azure-sdk/public/_build/results?buildId=1319619&view=logs&j=a3141784-dfa9-5792-78cc-844daee2d774&t=b2b6de04-64e4-5812-4fff-06c02d19f4c2&l=35

Step 1/15 : ARG PYTHON_VERSION="3.9.6"
Step 2/15 : FROM python:${PYTHON_VERSION}-alpine3.15
manifest for python:3.9.6-alpine3.15 not found: manifest unknown: manifest unknown

We need to use a valid tag from https://hub.docker.com/_/python.

I think we can use 3.10.2-alpine3.15 which will solve #19857 (comment) by the way.

You're right, my bad.

@jiasli
jiasli requested a review from evelyn-ys January 25, 2022 03:42
@jiasli jiasli changed the title [Packaging] Dockerfile base image from Alpine 3.14 to 3.15 [Packaging] Update Dockerfile base image from Alpine 3.14 to 3.15 Jan 25, 2022
@jiasli
jiasli merged commit ac9b76d into Azure:dev Jan 25, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

customer-reported Issues that are reported by GitHub users external to the Azure organization.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants