Skip to content

[Service Connector] az connection create: Add new param --customized-keys#25515

Merged
kairu-ms merged 5 commits into
Azure:devfrom
xfz11:sc/customizedkey
Feb 24, 2023
Merged

[Service Connector] az connection create: Add new param --customized-keys#25515
kairu-ms merged 5 commits into
Azure:devfrom
xfz11:sc/customizedkey

Conversation

@xfz11
Copy link
Copy Markdown
Contributor

@xfz11 xfz11 commented Feb 20, 2023

Related command

Description

Testing Guide

History Notes

[Component Name 1] BREAKING CHANGE: az command a: Make some customer-facing breaking change
[Component Name 2] az command b: Add some customer-facing feature


This checklist is used to make sure that common guidelines for a pull request are followed.

@ghost ghost added the Auto-Assign Auto assign by bot label Feb 20, 2023
@ghost ghost requested review from jsntcy and zhoxing-ms February 20, 2023 08:11
@ghost ghost assigned zhoxing-ms Feb 20, 2023
@ghost ghost added this to the Feb 2023 (2023-03-07) milestone Feb 20, 2023
@ghost ghost requested a review from yonzhan February 20, 2023 08:11
@ghost ghost added the Web Apps az webapp label Feb 20, 2023
@ghost ghost requested a review from wangzelin007 February 20, 2023 08:11
@xfz11 xfz11 changed the title [Service Connector] az webapp connection create: support customized keys [Service Connector] az webapp connection create: Add new param --customized-keys Feb 20, 2023
@yonzhan
Copy link
Copy Markdown
Collaborator

yonzhan commented Feb 20, 2023

Service Connector

Comment thread src/azure-cli/azure/cli/command_modules/serviceconnector/_params.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/serviceconnector/action.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/serviceconnector/custom.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/serviceconnector/custom.py
Comment thread src/azure-cli/azure/cli/command_modules/serviceconnector/custom.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/serviceconnector/custom.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/serviceconnector/custom.py
@houk-ms houk-ms removed the Web Apps az webapp label Feb 21, 2023
@xfz11 xfz11 changed the title [Service Connector] az webapp connection create: Add new param --customized-keys [Service Connector] az connection create: Add new param --customized-keys Feb 22, 2023
fix

fix

lint

Revert "update"

This reverts commit e5e04fcfd35abc70b3124d3f07023da8985ea720.
Comment thread src/azure-cli/azure/cli/command_modules/serviceconnector/custom.py Outdated
Comment thread src/azure-cli/azure/cli/command_modules/serviceconnector/_params.py Outdated
@xfz11
Copy link
Copy Markdown
Contributor Author

xfz11 commented Feb 24, 2023

@kairu-ms Can you help merge the PR?

@kairu-ms kairu-ms merged commit 0e4f5c4 into Azure:dev Feb 24, 2023
avgale pushed a commit to avgale/azure-cli that referenced this pull request Aug 24, 2023
…ed-keys` (Azure#25515)

* support customized keys

* extension compatible

* reset test

* update

fix

fix

lint

Revert "update"

This reverts commit e5e04fcfd35abc70b3124d3f07023da8985ea720.

* update param
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants