{packaging} Remove urllib3 secure extra - #26524
Closed
Major Hayden (major) wants to merge 1 commit into
Closed
Conversation
The `secure` extra package from urllib3 was deprecated a long time ago and many Linux distributions, including Fedora, no longer include it in their packages. Signed-off-by: Major Hayden <major@redhat.com>
️✔️AzureCLI-FullTest
|
|
Validation for Breaking Change Starting...
Thanks for your contribution! |
ghost
added
the
customer-reported
|
Thank you for your contribution major! We will review the pull request and get back to you soon. |
ghost
requested a review
from Jiashuo Li (jiasli)
May 24, 2023 16:37
Collaborator
|
packaging |
ghost
requested review from
Hang (bebound),
ZelinWang (wangzelin007) and
Yong Zhang (yonzhan)
May 24, 2023 16:37
Contributor
|
Thanks Major Hayden (@major) for the contribution, we are already working on this topic in #23494. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
N/A
Description
The
secureextra package from urllib3 was deprecated a long time ago and many Linux distributions, including Fedora, no longer include it in their packages.Testing Guide
No testing changes needed.
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.