{App Service} Remove usages of deprecated inject_into_urllib3 - #26538
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
ghost
added
the
Collaborator
|
App Service |
ghost
requested a review
from Xing Zhou (zhoxing-ms)
May 26, 2023 04:15
Jiashuo Li (jiasli)
marked this pull request as ready for review
May 26, 2023 05:37
Jiashuo Li (jiasli)
requested review from
Yu Chen (jsntcy) and
Julie Zhu (yanzhudd)
as code owners
May 26, 2023 05:37
Hang (bebound)
approved these changes
May 31, 2023
Xing Zhou (zhoxing-ms)
approved these changes
May 31, 2023
Contributor
|
Silas Strawn (@StrawnSC) Could you please help review this PR? It would be better if you are willing to do some related tests |
Yu Chen (jsntcy)
approved these changes
Jun 2, 2023
Silas Strawn (StrawnSC)
self-requested a review
June 2, 2023 22:49
Silas Strawn (StrawnSC)
approved these changes
Jun 2, 2023
Contributor
|
LGTM -- pulled the code locally and ran the following:
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
A supplementary PR for #23494
According to https://urllib3.readthedocs.io/en/stable/reference/contrib/pyopenssl.html
Since we have dropped support for Python 2 (#11363), we should remove usages of deprecated
inject_into_urllib3. Otherwise, in the future,urllib3v2.1.0 will raise an exception wheninject_into_urllib3is called (urllib3/urllib3#2680).