[App Service] az functionapp create: Add DAPR support for Centauri apps - #27589
Merged
Conversation
kamperiadis
requested review from
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
October 12, 2023 15:19
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
Bot
added this to the
October 2023 (2023-11-15)❗ Breaking change release ❗ milestone
|
| rule | cmd_name | rule_message | suggest_message |
|---|---|---|---|
| functionapp config container set | cmd functionapp config container set added parameter dapr_app_id |
||
| functionapp config container set | cmd functionapp config container set added parameter dapr_app_port |
||
| functionapp config container set | cmd functionapp config container set added parameter dapr_enable_api_logging |
||
| functionapp config container set | cmd functionapp config container set added parameter dapr_http_max_request_size |
||
| functionapp config container set | cmd functionapp config container set added parameter dapr_http_read_buffer_size |
||
| functionapp config container set | cmd functionapp config container set added parameter dapr_log_level |
||
| functionapp config container set | cmd functionapp config container set added parameter enable_dapr |
||
| functionapp create | cmd functionapp create added parameter dapr_app_id |
||
| functionapp create | cmd functionapp create added parameter dapr_app_port |
||
| functionapp create | cmd functionapp create added parameter dapr_enable_api_logging |
||
| functionapp create | cmd functionapp create added parameter dapr_http_max_request_size |
||
| functionapp create | cmd functionapp create added parameter dapr_http_read_buffer_size |
||
| functionapp create | cmd functionapp create added parameter dapr_log_level |
||
| functionapp create | cmd functionapp create added parameter enable_dapr |
microsoft-github-policy-service
Bot
requested review from
wangzelin007 and
yonzhan
October 12, 2023 15:19
Collaborator
|
AppService |
microsoft-github-policy-service
Bot
requested review from
JennyLawrance,
ebencarek,
howang-ms,
ruslany,
sanchitmehta and
vinisoto
October 12, 2023 15:19
Contributor
Author
|
This PR requires updating the SDK version |
microsoft-github-policy-service
Bot
requested review from
Greedygre,
Juliehzl,
chinadragon0515,
jijohn14,
pagariyaalok,
torosent and
vturecek
October 12, 2023 15:19
3 tasks
Contributor
|
Could you please resolve these CI issues? |
zhoxing-ms
reviewed
Nov 6, 2023
zhoxing-ms
reviewed
Nov 6, 2023
zhoxing-ms
reviewed
Nov 6, 2023
zhoxing-ms
reviewed
Nov 6, 2023
Contributor
|
@kamperiadis Please note that we are launching the release for this sprint this week. Please resolve all comments and conflicts by Tomorrow, otherwise the release of this PR will have to be postponed to the next sprint (on 12-05) |
zhoxing-ms
changed the title
az functionapp create: Add DAPR support for Centauri appsaz functionapp create: Add DAPR support for Centauri apps
zhoxing-ms
modified the milestones:
October 2023 (2023-11-14)❗ Breaking change release ❗,
November 2023 (2023-12-05)
Contributor
|
@kamperiadis Could you please resolve these CI issues? |
zhoxing-ms
modified the milestones:
November 2023 (2023-12-05),
December 2023 (2024-01-02)
Contributor
Author
|
@zhoxing-ms These tests are failing because it requires this PR to be merged first in order to use the new API version. Can you please review that other PR? Thank you. |
Contributor
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Contributor
That PR has been merged. |
kamperiadis
commented
Dec 13, 2023
| JMESPathCheck('linuxFxVersion', 'PowerShell|7.2')]) | ||
|
|
||
|
|
||
| class FunctionappDapr(LiveScenarioTest): |
Contributor
Author
There was a problem hiding this comment.
Note: had to keep this test in live mode because it would fail otherwise as it would somehow not find 'operationresults' polling matches in the recording but would always succeed in live mode.
arroyc
approved these changes
Dec 14, 2023
| functionapp_name | ||
| )) | ||
|
|
||
| time.sleep(1200) |
There was a problem hiding this comment.
is this 1200 just be on safer side that the functionapp config command will be finished by then?
Contributor
Author
There was a problem hiding this comment.
Yes, otherwise, we get a 409 error since the previous operation is not done
yanzhudd
approved these changes
Dec 15, 2023
MaxHorstmann
pushed a commit
to MaxHorstmann/azure-cli
that referenced
this pull request
Jan 19, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az functionapp createaz functionapp config container setDescription
We want to support DAPR for Azure Functions on container app environments.
Testing Guide
az containerapp env createaz functionapp config container set -g {} -n {} --dapr-app-id daprappid1 --dapr-app-port 80 --dal --dhmrs 6 --dhrbs 60 --dapr-log-level warn --enabled-dapr falseThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.