[AKS] az aks: Support IP-based Load Balancer and Instance Level Public IP Tags#27910
Merged
Conversation
nilo19
requested review from
andyliuliming,
jsntcy,
kairu-ms,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
|
Hi @nilo19, |
❌AzureCLI-BreakingChangeTest
|
Collaborator
|
AKS |
microsoft-github-policy-service
Bot
added
Auto-Assign
nilo19
changed the title
az aks create --load-balancer-backend-pool-type, `az …--load-balancer-backend-pool-type, aks update --load-balancer-backend-pool-type, az aks create --node-public-ip-tags andaz aks nodepool add --node-public-ip-tags
nilo19
changed the title
--load-balancer-backend-pool-type, aks update --load-balancer-backend-pool-type, az aks create --node-public-ip-tags andaz aks nodepool add --node-public-ip-tags--load-balancer-backend-pool-type, aks update --load-balancer-backend-pool-type, az aks create --node-public-ip-tags and az aks nodepool add --node-public-ip-tags
nilo19
changed the title
--load-balancer-backend-pool-type, aks update --load-balancer-backend-pool-type, az aks create --node-public-ip-tags and az aks nodepool add --node-public-ip-tagsaz aks create --load-balancer-backend-pool-type, aks update --load-balancer-backend-pool-type, az aks create --node-public-ip-tags and az aks nodepool add --node-public-ip-tags
nilo19
changed the title
az aks create --load-balancer-backend-pool-type, aks update --load-balancer-backend-pool-type, az aks create --node-public-ip-tags and az aks nodepool add --node-public-ip-tags--load-balancer-backend-pool-type, to az aks create and az aks update, add --node-public-ip-tags to az aks create and az aks nodepool add`
nilo19
changed the title
--load-balancer-backend-pool-type, to az aks create and az aks update, add --node-public-ip-tags to az aks create and az aks nodepool add`--load-balancer-backend-pool-type, to az aks create and az aks update, add --node-public-ip-tags to az aks create and az aks nodepool add`
nilo19
force-pushed
the
feat/node-ip
branch
2 times, most recently
from
ed2e76e to
3ff8f04
Compare
Member
|
The PR title is a little messy, would you split it into several notes and put it under section |
nilo19
changed the title
--load-balancer-backend-pool-type, to az aks create and az aks update, add --node-public-ip-tags to az aks create and az aks nodepool add`
Member
Author
Changed. Would this be acceptable? |
Member
|
please keep the formatting, taking
would be better |
Member
Author
done |
yanzhudd
reviewed
Nov 28, 2023
| - name: --load-balancer-backend-pool-type | ||
| type: string | ||
| short-summary: Load balancer backend pool type. | ||
| long-summary: Load balancer backend pool type, supported values are nodeIP and nodeIPConfiguration. |
Contributor
There was a problem hiding this comment.
If the value of this parameter is enumerable, it is suggested to use arg_type=get_enum_type() to define the param. After that, it is not necessary to manually specify the available options.
Member
Author
There was a problem hiding this comment.
Fixed, please take a look.
yanzhudd
reviewed
Nov 28, 2023
| - name: --load-balancer-backend-pool-type | ||
| type: string | ||
| short-summary: Load balancer backend pool type. | ||
| long-summary: Load balancer backend pool type, supported values are nodeIP and nodeIPConfiguration. |
yanzhudd
reviewed
Nov 28, 2023
Comment on lines
+229
to
+230
| c.argument('load_balancer_backend_pool_type', arg_type=get_enum_type(backend_pool_types), | ||
| validator=validate_load_balancer_backend_pool_type) |
Contributor
There was a problem hiding this comment.
After defined with arg_type=get_enum_type(backend_pool_types), it is not necessary to validate the input manually.
Suggested change
| c.argument('load_balancer_backend_pool_type', arg_type=get_enum_type(backend_pool_types), | |
| validator=validate_load_balancer_backend_pool_type) | |
| c.argument('load_balancer_backend_pool_type', arg_type=get_enum_type(backend_pool_types)) |
Member
Author
|
@FumingZhang can we get this merged? |
yanzhudd
previously approved these changes
Nov 29, 2023
Member
Author
|
@jsntcy @kairu-ms @zhoxing-ms can we merge this today? |
Contributor
Sorry, PRs cannot be merged during our release process. Once the release is complete, we would merge it. |
Member
Author
|
@yanzhudd when will the release process be done? |
Contributor
It seems that approval from the core module owner is required. |
zhoxing-ms
reviewed
Dec 6, 2023
zhoxing-ms
reviewed
Dec 6, 2023
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
zhoxing-ms
changed the title
az aks: Support IP-based Load Balancer and Instance Level Public IP Tags
zhoxing-ms
reviewed
Dec 6, 2023
Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
Member
Author
|
@zhoxing-ms any other comments? |
zhoxing-ms
approved these changes
Dec 11, 2023
wangzelin007
approved these changes
Dec 11, 2023
MaxHorstmann
pushed a commit
to MaxHorstmann/azure-cli
that referenced
this pull request
Jan 19, 2024
…lic IP Tags (Azure#27910) * feat: support `az aks create --load-balancer-backend-pool-type`, `az aks update --load-balancer-backend-pool-type`, `az aks create --node-public-ip-tags` and `az aks nodepool add --node-public-ip-tags`. * chore: set arg type to enum for backend_pool_type * chore: remove backend pool type validator * Update src/azure-cli/azure/cli/command_modules/acs/_help.py Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> * Update src/azure-cli/azure/cli/command_modules/acs/_help.py Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> * Update src/azure-cli/azure/cli/command_modules/acs/_help.py Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com> --------- Co-authored-by: Xing Zhou <Zhou.Xing@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
Support the above commands. Ref: Azure/azure-cli-extensions#5536 and Azure/azure-cli-extensions#5355
Testing Guide
History Notes
[AKS]
az aks create/update: Add new parameter--load-balancer-backend-pool-typeto define the Load Balancer backend pool type of managed inbound backend pool[AKS]
az aks create: Add parameter--node-public-ip-tagsto specify the ipTags of the node public IPs[AKS]
az aks nodepool: Add parameter--node-public-ip-tagsto specify the ipTags of the node public IPsThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.