{AKS} az aks create | az aks nodepool add/update: Fix NSG control live tests and cmd description#27947
Merged
Merged
Conversation
clnv
requested review from
andyliuliming,
jsntcy,
yanzhudd and
zhoxing-ms
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
AKS |
microsoft-github-policy-service
Bot
requested review from
FumingZhang and
yonzhan
microsoft-github-policy-service
Bot
added
Auto-Assign
FumingZhang
reviewed
Nov 30, 2023
| self.kwargs.update({ | ||
| 'asg1_id': asg1['id'], | ||
| 'asg2_id': asg2['id'], | ||
| 'asg_ids_argument': '--nodepool-asg-ids {}'.format(' '.join(asg_ids)), |
Member
There was a problem hiding this comment.
Queued live test to validate the change, test passed!
yanzhudd
approved these changes
Nov 30, 2023
Contributor
|
Now CLI is in a release process and PRs cannot be merged. Once release is complete, we would merge it. |
MaxHorstmann
pushed a commit
to MaxHorstmann/azure-cli
that referenced
this pull request
Jan 19, 2024
… live tests and cmd description (Azure#27947)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
Description
refer: #27900
Fix the live tests and command descriptions.
Testing Guide
History Notes
az aks create: Fix live tests and command description.az aks nodepool add: Fix live tests and command description.az aks nodepool update: Fix live tests and command description.This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.