{Core} Bump msal-extensions to 1.2.0b1 - #28747
Merged
Merged
Conversation
️✔️AzureCLI-FullTest
|
azure-client-tools-bot-prd
Bot
added this to the
May 2024 (2024-05-21)❗ Breaking change release ❗ milestone
|
Hi Jiashuo Li (@jiasli), |
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Bump msal-extensions |
Jiashuo Li (jiasli)
modified the milestones:
May 2024 (2024-05-21)❗ Breaking change release ❗,
April 2024 (2024-04-30)
microsoft-github-policy-service
Bot
requested review from
Yong Zhang (yonzhan) and
Xing Zhou (zhoxing-ms)
April 15, 2024 11:05
microsoft-github-policy-service
Bot
added
the
ARM
microsoft-github-policy-service
Bot
added
Account
Jiashuo Li (jiasli)
force-pushed
the
bump-msal-extensions
branch
from
April 16, 2024 00:34
f6153f8 to
12bb0a1
Compare
Jiashuo Li (jiasli)
changed the title
msal-extensions to 1.2.0a1msal-extensions to 1.2.0b1
| 'jmespath', | ||
| 'knack~=0.11.0', | ||
| 'msal-extensions~=1.0.0', | ||
| 'msal-extensions==1.2.0b1', |
Contributor
Author
There was a problem hiding this comment.
We have to pin the version. Using ~= will allow 1.2.0 which will contain breaking changes compared to 1.2.0b1: AzureAD/microsoft-authentication-extensions-for-python#128 (comment)
See https://packaging.python.org/en/latest/specifications/version-specifiers/#compatible-release
Jiashuo Li (jiasli)
changed the title
msal-extensions to 1.2.0b1msal-extensions to 1.2.0b1
Hang (bebound)
approved these changes
Apr 16, 2024
Jiashuo Li (jiasli)
marked this pull request as ready for review
April 16, 2024 05:54
Jiashuo Li (jiasli)
requested review from
Zhiyi Huang (calvinhzy),
Yishi Wang (evelyn-ys),
Yu Chen (jsntcy),
kai ru (kairu-ms) and
Ethan Yang (necusjz)
as code owners
April 16, 2024 05:54
Shiying Chen (MoChilia)
approved these changes
Apr 16, 2024
Yishi Wang (evelyn-ys)
approved these changes
Apr 16, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix #28737
Related command
az loginaz account get-access-tokenDescription
Bump
msal-extensionsto 1.2.0b1 in order to adopt AzureAD/microsoft-authentication-extensions-for-python#128 and fix AzureAD/microsoft-authentication-extensions-for-python#127.Testing Guide
Notice executing
az account get-access-tokentwice will return the sameexpiresOnandexpires_on.History Notes
[Core] Fix #28737: Fix token cache for service principal authentication