{Core} Bump MSAL to 1.28.1 and PyMSALRuntime to 0.16.2 - #29088
Merged
Conversation
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Collaborator
|
Core |
microsoft-github-policy-service
Bot
added
Account
Yong Zhang (yonzhan)
previously approved these changes
Jun 4, 2024
| PyGithub==1.55 | ||
| PyJWT==2.4.0 | ||
| pymsalruntime==0.14.2a1 | ||
| pymsalruntime==0.16.2a1 |
Contributor
Author
There was a problem hiding this comment.
There is no PyMSALRuntime 0.15.0, 0.16.0 or 0.16.1:
https://pypi.org/project/pymsalruntime/#history
This is because the fix for User cancelled the Accounts Control Operation is only in MSALRuntime 0.16.2. Backporting the fix to 0.14.2 is throw-away work.
Contributor
There was a problem hiding this comment.
Backporting the fix to 0.14.2 is throw-away work.
FYI: Actually, that was our preferred approach. We (MsalRuntime and Msal Python team) attempted that, but encountered technical difficulties, so we settled with 0.16.2 this time.
Contributor
Author
There was a problem hiding this comment.
I use the word "throw-away" because users tend to use a newer version when available.
Jiashuo Li (jiasli)
force-pushed
the
bump-msal
branch
from
June 12, 2024 08:35
fdfbf0d to
c935e5e
Compare
Jiashuo Li (jiasli)
changed the title
Jiashuo Li (jiasli)
force-pushed
the
bump-msal
branch
from
June 12, 2024 08:46
c935e5e to
99b27e6
Compare
Jiashuo Li (jiasli)
marked this pull request as ready for review
June 12, 2024 08:47
Ray Luo (rayluo)
approved these changes
Jun 13, 2024
Hang (bebound)
approved these changes
Jun 17, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az loginDescription
Fix #28997
Bump PyMSALRuntime to 0.16.2 to solve #28997. Bump MSAL to 1.28.1 to allow PyMSALRuntime 0.16.2: AzureAD/microsoft-authentication-library-for-python@ddb94b2
Testing Guide
Open Windows Terminal as administrator, run
History Notes
[Core] Fix #28997: Fix error "User cancelled the Accounts Control Operation" when logging in with WAM as Administrator