[NetAppFiles] Anounce deprecation on subvolumes#33484
Open
audunn wants to merge 1 commit into
Open
Conversation
audunn
requested review from
DanielMicrosoft,
bebound,
jiasli,
necusjz and
yonzhan
as code owners
️✔️AzureCLI-FullTest
|
️✔️AzureCLI-BreakingChangeTest
|
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Adds breaking-change registrations for NetApp Files to communicate upcoming removals/deprecations in the CLI.
Changes:
- Import
register_argument_deprecatefromazure.cli.core.breaking_change. - Deprecate the
--enable-subvolumesargument fornetappfiles volume create. - Deprecate the
--enable-subvolumesargument fornetappfiles volume update.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+12
to
+14
| register_argument_deprecate('netappfiles volume create', '--enable-subvolumes', message='--enable-subvolumes is being deprecated and will be removed in a future release.') | ||
|
|
||
| register_argument_deprecate('netappfiles volume update', '--enable-subvolumes', message='--enable-subvolumes is being deprecated and will be removed in a future release.') No newline at end of file |
Comment on lines
+12
to
+14
| register_argument_deprecate('netappfiles volume create', '--enable-subvolumes', message='--enable-subvolumes is being deprecated and will be removed in a future release.') | ||
|
|
||
| register_argument_deprecate('netappfiles volume update', '--enable-subvolumes', message='--enable-subvolumes is being deprecated and will be removed in a future release.') No newline at end of file |
microsoft-github-policy-service
Bot
added
NetAppFiles
Collaborator
|
NetAppFiles |
Member
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
Member
|
@audunn i refined the title, so it won't fail ci. feel free to fix the other failures. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related command
az netappfiles
Description
This adds deprecation anouncement on subvolumes feature
Testing Guide
History Notes
[NetAppFiles]
az netappfiles subvolumes: Add deprecation noticeaz netappfiles subvolumecommand group is being deprecated and will be removed in a future release[NetAppFiles]
az netappfiles volume create/update: Add deprecation notice--enable-subvolumesis being deprecated and will be removed in a future releaseThis checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.