Skip to content

[AKS] Stabilize live tests and preserve IPv4 outbound default - #33886

Draft
FumingZhang wants to merge 5 commits into
Azure:devfrom
FumingZhang:fix/aks-live-test-remaining-failures
Draft

[AKS] Stabilize live tests and preserve IPv4 outbound default#33886
FumingZhang wants to merge 5 commits into
Azure:devfrom
FumingZhang:fix/aks-live-test-remaining-failures

Conversation

@FumingZhang

@FumingZhang FumingZhang commented Aug 13, 2026

Copy link
Copy Markdown
Member

🤖 PR Validation — ️✔️ All clear

Breaking Changes Tests
️✔️ None ️✔️ 130/130

Related command

az aks create, az aks update, az aks nodepool add, az aks nodepool update, az aks nodepool auto-scale

Description

This PR fixes the remaining actionable failures found in the AKS CLI live-test runner and restores the historical managed outbound IPv4 default.

  • Register the Container Insights solution payload as a scenario-test formatting value so retry formatting does not interpret inline JSON braces as placeholders.
  • Create and pass an explicit Log Analytics workspace before enabling the monitoring add-on.
  • Wait for VMS cluster updates between sequential autoscaler operations during live and recording runs, while avoiding unrecorded requests during playback.
  • Disable recording for retry-enabled live runs and discard temporary cassette traffic captured while preparers override the recording flag, preventing partial recordings that cannot replay normally.
  • Keep GA feature scenarios enabled so API-version and rollout regressions remain visible.
  • Default managedOutboundIPs.count to 1 when only the IPv6 count is supplied. This preserves the behavior that existed before azure-mgmt-containerservice 41 changed the SDK constructor default from 1 to None, while retaining explicit or existing IPv4 values.
  • Remove the explicit IPv4-count workaround from the dual-stack scenario so it covers the restored default.

Testing Guide

  • python -m pytest -q src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_loadbalancer.py — 6 passed.
  • python -m pytest -q src/azure-cli/azure/cli/command_modules/acs/tests/latest/test_aks_provisioning_retry.py — 31 passed, 5 subtests passed.
  • Dual-stack scenario replay — 1 passed.
  • Full ACS validation for the live-test stability changes — 980 passed, 84 skipped, 4 subtests passed.
  • python -m py_compile for all changed Python files — passed.
  • git diff --check — passed.

History Notes

[AKS] az aks create, az aks update: Preserve the default managed outbound IPv4 count when only the IPv6 count is provided


This checklist is used to make sure that common guidelines for a pull request are followed.

FumingZhang and others added 4 commits August 6, 2026 03:42
Avoid retry formatting of inline JSON, initialize Container Insights workspaces before AKS creation, wait between sequential VMS pool operations, and skip live scenarios whose service toggles are unavailable in the runner subscription.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Artifact Streaming is GA and Control Plane Metrics is on the GA rollout path, so retain their live coverage instead of masking API-version and toggle-rollout failures.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Gate the VMS autoscaler settle checks to live and recording runs so existing replay cassettes do not issue unrecorded GET requests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Preserve the historical IPv4 managed outbound IP default when only the IPv6 count is supplied. Keep explicit and existing IPv4 values unchanged, and cover create and update behavior with focused tests.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

Retry polling and refetch requests cannot replay through the normal scenario path. Disable recording for these live runs and discard any temporary cassette traffic captured while preparers override the recording flag.\n\nCo-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

act-observability-squad AKS az aks/acs/openshift Auto-Assign Auto assign by bot

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants