Skip to content

[Container] Support --no-wait on container start/restart. #8600

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tjprescott merged 1 commit into from
Feb 21, 2019
Merged

[Container] Support --no-wait on container start/restart. #8600

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/command_modules/azure-cli-container/HISTORY.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,8 @@
Release History
===============

* `container start/restart`: Added `--no-wait` argument.

0.3.13
++++++
* Adding 'az container start' command
Expand Down
4 changes: 2 additions & 2 deletions src/command_modules/azure-cli-container/azure/cli/command_modules/container/commands.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -27,6 +27,6 @@ def load_command_table(self, _):
g.custom_command('attach', 'attach_to_container')

with self.command_group('container', container_group_sdk) as g:
g.command('restart', 'restart')
g.command('restart', 'restart', supports_no_wait=True)
g.command('stop', 'stop')
Copy link
Copy Markdown
Contributor

@adewaleo adewaleo Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Stop doesn't need a no wait?

Copy link
Copy Markdown
Member Author

@tjprescott tjprescott Feb 21, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No. As far as I can tell, it is never long-running.

g.command('start', 'start')
g.command('start', 'start', supports_no_wait=True)