don't retry writes#301
Merged
Merged
Conversation
kushagraThapar
commented
Dec 19, 2019
kushagraThapar
commented
Member
- SDK will not retry on write operations on Timeout Exception.
kushagraThapar
requested review from
David-Noble-at-work and
moderakh
as code owners
December 19, 2019 21:08
moderakh
approved these changes
Dec 19, 2019
moderakh
left a comment
moderakh
left a comment
Contributor
There was a problem hiding this comment.
Please talk to HA folks to ensure this doesn't break failover support etc.
…/Azure/azure-cosmosdb-java into users/moderakh/dont-retry-writes
| .nullException() | ||
| .shouldRetry(true) | ||
| .backOfTime(i > 0 ? Duration.ofMillis(ClientRetryPolicy.RetryIntervalInMS) : Duration.ZERO) | ||
| .shouldRetry(false) |
Member
There was a problem hiding this comment.
Ideal to cover all test scenarios. Please doc explore any gaps and cover them
sharma-pankaj
approved these changes
Dec 23, 2019
This was referenced Jan 7, 2020
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.