Validate target service resource#1181
Merged
Merged
Conversation
Fallback to envName + serviceName has been around prior to public preview, and no longer makes much sense given that it's not a well-known resource abbreviation.
weikanglim
requested review from
ellismg,
hemarina,
jongio,
vhvb1989 and
wbreza
as code owners
November 17, 2022 23:25
weikanglim
commented
Nov 17, 2022
Member
ellismg
reviewed
Nov 17, 2022
ellismg
left a comment
Member
There was a problem hiding this comment.
Will take a more in depth pass tomorrow (and sign off) but overal this looked like the right thing to me. Thanks for the improvements here, love the actionable error messages!
ellismg
approved these changes
Nov 18, 2022
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsStandalone Binary
Container |
Closed
1 task
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
envName+serviceName. This logic predates public preview ofazd, and the abbreviated fallback no longer makes sense inazd.azd shownot working as expected when an explicitresourceNameis specified inazure.yamlAddresses #1037