Skip to content

fix persistSettings regression #4450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vhvb1989 merged 3 commits into from
Oct 17, 2024
+6 −7
Merged

fix persistSettings regression #4450

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
ff265af
Fixing regression for persistSettings() which is trying to read value…
vhvb1989 Oct 16, 2024
3c7c714
comment
vhvb1989 Oct 17, 2024
00bd1cf
cl
vhvb1989 Oct 17, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 2 additions & 6 deletions cli/azd/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,14 +1,10 @@
# Release History

## 1.11.0-beta.1 (Unreleased)

### Features Added

### Breaking Changes
## 1.10.3 (2024-10-16)

### Bugs Fixed

### Other Changes
- [[4450]](https://github.com/Azure/azure-dev/pull/4450) fix `persistSettings` alpha feature.

## 1.10.2 (2024-10-08)

Expand Down
3 changes: 3 additions & 0 deletions cli/azd/pkg/containerapps/container_app.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -146,6 +146,9 @@ func (cas *containerAppService) persistSettings(
aca, err := cas.getContainerApp(ctx, subscriptionId, resourceGroupName, appName, options)
if err != nil {
log.Printf("failed getting current aca settings: %v. No settings will be persisted.", err)
// if the container app doesn't exist, there's nothing for us to update in the desired state,
// so we can just return the existing state as is.
return obj, nil
Comment thread
vhvb1989 marked this conversation as resolved.
}

objConfig := config.NewConfig(obj)
Expand Down
2 changes: 1 addition & 1 deletion cli/version.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
1.11.0-beta.1
1.10.3