Use Redis AVM's secretsExportConfiguration param to store secrets in Key Vault#4719
Conversation
wbreza
left a comment
There was a problem hiding this comment.
Looks good - just a couple questions.
weikanglim
left a comment
There was a problem hiding this comment.
LGTM, thanks for the clean change.
FYI @JeffreyCA, I'm not sure if it's helpful but the tests in scaffold_test.go does validate the Bicep syntax of the resulting generation. I also logged #4720 for us to move this up a layer where we can have azure.yaml test cases as input, and add scenario tests that way.
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
JeffreyCA
left a comment
There was a problem hiding this comment.
LGTM, thanks for the clean change.
FYI @JeffreyCA, I'm not sure if it's helpful but the tests in
scaffold_test.godoes validate the Bicep syntax of the resulting generation. I also logged #4720 for us to move this up a layer where we can haveazure.yamltest cases as input, and add scenario tests that way.
Thanks, that's good to know
Closes #4681
v0.9.0 of the Redis AVM adds support for
secretsExportConfiguration, a standardized input param used by several other AVMs to export access keys and other secrets to Azure Key Vault after the resource has been provisioned. (Reference)This PR updates compose's Bicep generation to use the new module version and
secretsExportConfigurationto write the Redis primary access key and connection string to Key Vault instead of our customset-redis-conn.bicepBicep module.Validation
Deployed a minimal Python Flask web app with Redis:
azure.yaml:
resources.bicep:
Python app code:
Key vault:
