[SJAD] compose: azd add support for storage accounts (blob service)#4730
Closed
JeffreyCA wants to merge 181 commits into
Closed
[SJAD] compose: azd add support for storage accounts (blob service)#4730JeffreyCA wants to merge 181 commits into
azd add support for storage accounts (blob service)#4730JeffreyCA wants to merge 181 commits into
Conversation
Support adding MySQL when run `azd init`
Fix typo by changing "DbMysql" to "DbMySql"
…or like this: "argetTypeNotSupported: Target resource type MICROSOFT.DBFORMYSQL/FLEXIBLESERVERS is not supported.".
2. Delete '1>&2' used for debug. 3. Add 'az tag create' to fix the problem about tag been deleted when creating service connector.
Use managed-identity instead of username and password
2. Update log about "failed to read spring application properties". 3. Fix bug about can not find frontend app and backend app at the same time. 4. Add service connector from aca to postgresql.
Use passwordless to connect to PostgreSQL in Azure Container Apps
…bs, and spring-kafka (#85)
…ble project (#103) * pre-check if it's a runnable project * when parent detection, add module check * fix UT * fix UT * fix UT * fix comments, and update the module check recursively * make pom artifact id is not same as the dir name * small fix * fix UT * small fix * clear mvn wrapper content * deprecate maven build hook, run mvn clean package before adding default dockerfile * remove unnecessary mvn wrapper files * remove unused func * fix UT and remove currentPomDir * introduce modulePoms * remove unused func, and refactor --------- Co-authored-by: haozhang <haozhan@microsoft.com>
* fix the sjad azd add cannot work bug
Co-authored-by: haozhang <haozhan@microsoft.com>
* add uts for app_init, detect_confirm, infra_confirm, and scaffold
JeffreyCA
commented
Jan 24, 2025
| return errors.New("name cannot contain consecutive hyphens") | ||
| } | ||
|
|
||
| err := names.ValidateLabelName(name) |
Contributor
Author
There was a problem hiding this comment.
I noticed ValidateLabelName uses a regex that checks for a minimum string length of 2 - is that intentional? I couldn't find in the RFC 1123 spec that it had to have a min length of 2.
var rfc1123LabelRegex = regexp.MustCompile(`^[a-zA-Z0-9][a-zA-Z0-9-]{0,61}[a-zA-Z0-9]$`)
...
if !rfc1123LabelRegex.MatchString(name) {
return errors.New("name must contain only lower-cased alphanumeric characters or '-', i.e. a-z, 0-9, or '-'")
}
JeffreyCA
changed the title
azd add support for storage accountsazd add support for storage accounts (blob service)
JeffreyCA
commented
Jan 25, 2025
| return fmt.Errorf("in azure.yaml, (%s) uses (%s), but (%s) doesn't", | ||
| userResourceName, usedResourceName, usedResourceName) | ||
| } | ||
| console.Message(ctx, fmt.Sprintf("\nInformation about environment variables:\n"+ |
Contributor
Author
There was a problem hiding this comment.
There's some duplication between this and add_preview.go, which also prints out the environment variables
JeffreyCA
changed the title
azd add support for storage accounts (blob service)azd add support for storage accounts (blob service)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #4716
This PR builds on top of #4473, adding
azd addsupport for storage accounts (blob service).These changes permit only one storage account resource and one storage container, but open to loosening these restrictions.