Skip to content

Repoman - Adding relative base path ./ to path rewrites. - #537

Merged
hattan merged 3 commits into
Azure:mainfrom
kaizentm:cse/add-relative-base-path
Sep 1, 2022
Merged

Repoman - Adding relative base path ./ to path rewrites.#537
hattan merged 3 commits into
Azure:mainfrom
kaizentm:cse/add-relative-base-path

Conversation

@hattan

@hattan hattan commented Aug 28, 2022

Copy link
Copy Markdown
Contributor

This PR addresses part of #524 , specifically adding ./ to local paths. This is needed to support Terraform local modules PR #532. A separate PR will be provided to add the ReWrite Rules section.

This PR introduces:

  • A utility method in repoman utils to add a base path that is platform specific "./" or ".\".
  • Changes to the repoman path rewrite normalization to add a base prefix.

Tests were conducted to verify the CI workflow for repoman generate and a test azd deployment was conducted against a test repo with the relative base path included "./"

Repo generation CI (on fork)

Resources Deployed via modified template:
image

Running Application:
image

hattan and others added 2 commits August 27, 2022 19:12
Co-authored-by: Hadwa Gaber <hadwaa@microsoft.com>
Co-authored-by: Hadwa Gaber <hadwaa@microsoft.com>

@wbreza wbreza left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment thread generators/repo/src/common/util.ts Outdated
Co-authored-by: Hadwa Gaber <hadwaa@microsoft.com>
@azure-sdk

Copy link
Copy Markdown
Collaborator

Repoman Generation Results

Repoman pushed changes to remotes for the following projects:

Project: todo-csharp-cosmos-sql

Remote: azure-samples-staging

Branch: pr/537

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-cosmos-sql -b pr/537

View Changes | Compare Changes


Project: todo-csharp-mongo

Remote: azure-samples-staging

Branch: pr/537

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-mongo -b pr/537

View Changes | Compare Changes


Project: todo-csharp-sql

Remote: azure-samples-staging

Branch: pr/537

You can initialize this project with:

azd init -t Azure-Samples/todo-csharp-sql -b pr/537

View Changes | Compare Changes


Project: todo-nodejs-mongo-aca

Remote: azure-samples-staging

Branch: pr/537

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-aca -b pr/537

View Changes | Compare Changes


Project: todo-nodejs-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/537

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo-swa-func -b pr/537

View Changes | Compare Changes


Project: todo-nodejs-mongo

Remote: azure-samples-staging

Branch: pr/537

You can initialize this project with:

azd init -t Azure-Samples/todo-nodejs-mongo -b pr/537

View Changes | Compare Changes


Project: todo-python-mongo-aca

Remote: azure-samples-staging

Branch: pr/537

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-aca -b pr/537

View Changes | Compare Changes


Project: todo-python-mongo-swa-func

Remote: azure-samples-staging

Branch: pr/537

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo-swa-func -b pr/537

View Changes | Compare Changes


Project: todo-python-mongo

Remote: azure-samples-staging

Branch: pr/537

You can initialize this project with:

azd init -t Azure-Samples/todo-python-mongo -b pr/537

View Changes | Compare Changes


@hattan
hattan requested a review from wbreza August 31, 2022 07:48

@ellismg ellismg left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@hattan
hattan merged commit 6ac302e into Azure:main Sep 1, 2022
vhvb1989 added a commit that referenced this pull request Jul 24, 2026
…9240)

* chore(deps): group Dependabot security updates into one PR

Addresses all open Dependabot alerts across the repo:

- cli/azd/extensions/azure.ai.rle: bump golang.org/x/crypto 0.49.0 -> 0.52.0
  and golang.org/x/net 0.52.0 -> 0.55.0 (alerts #456-#469). Note x/net
  requires 0.55.0 for full remediation of #456.
- ext/vscode: js-yaml -> 4.3.0, brace-expansion -> 2.1.2 & 5.0.7
  (alerts #539, #540, #541)
- ext/azuredevops/setupAzd: adm-zip -> 0.6.0, azure-pipelines-task-lib -> 5.278.0,
  brace-expansion -> 1.1.16 & 2.1.2 (alerts #535, #537, #538)
- cli/azd/test/eval: brace-expansion -> 1.1.16 (alert #536)

Supersedes and consolidates #9093 and #9215.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2cef6dea-2ec8-4538-8e55-7a2b0dfa196c

* ci: make azdo-extension npm steps non-blocking on PR builds

The azdo-extension pipeline currently fails on the self-hosted Linux and
Windows agents because they cannot reach registry.npmjs.org (npm EPERM
egress block); `npm i -g npm` fails before any dependency is resolved.
Build Mac (hosted pool) and the vscode build (same self-hosted pool) are
unaffected, confirming this is an agent egress issue, not a code problem.

Make the npm-dependent steps (install, test, package) non-blocking for PR
validation builds only (Build.Reason == PullRequest) so this gate does not
block unrelated PRs such as the grouped Dependabot security update. Release
and CD builds on main remain strict, so CodeQL and artifact generation are
unaffected. Artifact staging is skipped on PR builds since the package step
may not produce a VSIX while the egress issue persists.

Tracking issue to fix the egress block and re-enable the gate: #9286

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2cef6dea-2ec8-4538-8e55-7a2b0dfa196c

* ci: trigger azdo pipeline PR validation on build template changes

Add the azuredevops build/stage templates to the release-azuredevops
pipeline PR and CI path filters so edits to the build job template are
validated by the azdo-extension pipeline (previously only changes under
ext/azuredevops or the root pipeline file triggered it).

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2cef6dea-2ec8-4538-8e55-7a2b0dfa196c

* ci: skip azdo-extension Sign stage on PR builds

Now that the BuildAndTest stage completes with issues (instead of hard
failing) on PR validation builds while the self-hosted agent npm egress
issue persists (#9286), the Sign stage began running on PRs and failed
because no vsix artifact is produced on PR builds. Signing is never
performed for PR builds, so gate the whole Sign stage to release/CI/manual
build reasons. Also add the sign/publish stage templates to the pipeline
PR path filters so template changes are validated.

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2cef6dea-2ec8-4538-8e55-7a2b0dfa196c

---------

Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Copilot-Session: 2cef6dea-2ec8-4538-8e55-7a2b0dfa196c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants