Skip to content

azd x support interactive #6367

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vhvb1989 merged 13 commits into from
Dec 17, 2025
Merged

azd x support interactive #6367

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
59c7d8e
Adding extension and grpc layer for services
vhvb1989 Nov 20, 2025
f2fc087
ignore binary
vhvb1989 Nov 20, 2025
84e396c
wip
vhvb1989 Nov 20, 2025
051b6d0
wip
vhvb1989 Nov 23, 2025
b16f742
Merge main into extension-concurx branch
vhvb1989 Dec 11, 2025
33aecc5
cspell
vhvb1989 Dec 11, 2025
fa333be
updates to mod
vhvb1989 Dec 11, 2025
bac1495
Support interactive invocation opt-in for extensions
vhvb1989 Dec 12, 2025
5575610
Merge branch 'main' of https://github.com/azure/azure-dev into azd-x-…
vhvb1989 Dec 12, 2025
27b4097
cleaner way to show interactive override from extensions owning the t…
vhvb1989 Dec 16, 2025
174f48d
Merge branch 'main' of https://github.com/azure/azure-dev into azd-x-…
vhvb1989 Dec 16, 2025
f7c52d9
revert and make interactive by default
vhvb1989 Dec 16, 2025
1915e6e
set interactive option for the call
vhvb1989 Dec 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 4 additions & 5 deletions cli/azd/cmd/extensions.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -182,11 +182,10 @@ func (a *extensionAction) Run(ctx context.Context) (*actions.ActionResult, error
}

options := &extensions.InvokeOptions{
Args: a.args,
Env: allEnv,
StdIn: a.console.Handles().Stdin,
StdOut: a.console.Handles().Stdout,
StdErr: a.console.Handles().Stderr,
Args: a.args,
Env: allEnv,
// cmd extensions are always interactive (connected to terminal)
Interactive: true,
}

_, err = a.extensionRunner.Invoke(ctx, extension, options)
Expand Down
31 changes: 18 additions & 13 deletions cli/azd/pkg/extensions/runner.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,11 +15,12 @@ import (
)

type InvokeOptions struct {
Args []string
Env []string
StdIn io.Reader
StdOut io.Writer
StdErr io.Writer
Args []string
Env []string
StdIn io.Reader
StdOut io.Writer
StdErr io.Writer
Interactive bool
}

type Runner struct {
Expand Down Expand Up @@ -51,16 +52,20 @@ func (r *Runner) Invoke(ctx context.Context, extension *Extension, options *Invo
runArgs = runArgs.WithEnv(options.Env)
}

if options.StdIn != nil {
runArgs = runArgs.WithStdIn(options.StdIn)
}
if options.Interactive {
runArgs = runArgs.WithInteractive(true)
} else {
if options.StdIn != nil {
runArgs = runArgs.WithStdIn(options.StdIn)
}

if options.StdOut != nil {
runArgs = runArgs.WithStdOut(options.StdOut)
}
if options.StdOut != nil {
runArgs = runArgs.WithStdOut(options.StdOut)
}

if options.StdErr != nil {
runArgs = runArgs.WithStdErr(options.StdErr)
if options.StdErr != nil {
runArgs = runArgs.WithStdErr(options.StdErr)
}
}

Comment thread
vhvb1989 marked this conversation as resolved.
runResult, err := r.commandRunner.Run(ctx, runArgs)
Expand Down
Loading