Updates unit tests based on recent schema changes#6393
Merged
Conversation
wbreza
requested review from
JeffreyCA,
hemarina,
rajeshkamal5050,
tg-msft,
vhvb1989 and
weikanglim
as code owners
December 17, 2025 19:26
wbreza
enabled auto-merge (squash)
December 17, 2025 19:27
Contributor
There was a problem hiding this comment.
Pull request overview
This PR updates a unit test in the azure.yaml schema validation tool to reflect recent changes to the published azure.yaml schema. The schema now allows additional properties at the root level ("additionalProperties": true), which means the previous test case that validated rejection of unknown fields would no longer fail. The test has been appropriately updated to verify a different schema validation scenario: missing the required name field.
Key Changes:
- Updated test data from an unknown field (
not_a_schema_field: true) to a minimal YAML with no required fields (some_field: value) - Updated assertion from checking for "additional properties not allowed" to "missing property 'name'"
- Added clear comment explaining the test validates missing required field
weikanglim
approved these changes
Dec 17, 2025
JeffreyCA
approved these changes
Dec 17, 2025
Contributor
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
azure.yamlschema now supports additional properties. Test started failing since it takes a runtime dependency against the published schema that was recently changed.Updates tests case to take schema changes into account.