fix: sanitize dots in repo name for federated identity credentials - #7040
Merged
Conversation
azd pipeline config fails when the GitHub repo name contains dots because federated identity credential names only allow letters, numbers, hyphens, and underscores. The repo slug was only replacing '/' with '-' but not handling dots or other special characters. Use a shared regex sanitizer (same pattern already used for branch names) to replace all invalid characters in the credential name. Also removes unnecessary url.PathEscape wrapping. Fixes #5948 Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
spboyer
requested review from
JeffreyCA,
hemarina,
vhvb1989,
wbreza and
weikanglim
as code owners
March 7, 2026 03:22
Contributor
There was a problem hiding this comment.
Pull request overview
This PR fixes azd pipeline config failures when GitHub repository names contain dots (or other special characters), which violate Azure's federated identity credential naming constraints. The fix introduces a shared regex sanitizer that replaces all disallowed characters with hyphens.
Changes:
- Introduced a shared
credentialNameSanitizerregex to replace characters not allowed in federated identity credential names (anything other than letters, numbers, hyphens, and underscores) - Applied the sanitizer to both repo slug and branch name sanitization, replacing the old inline
strings.ReplaceAllfor/and a per-call compiled regex for branches - Removed the now-unnecessary
url.PathEscape()wrapping from credential names and thenet/urlimport
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
cli/azd/pkg/pipeline/github_provider.go |
Added shared credentialNameSanitizer regex; applied it to repo slug and branch name sanitization; removed url.PathEscape wrapping and net/url import |
cli/azd/pkg/pipeline/github_provider_test.go |
Added 5 table-driven tests validating the credential name sanitizer regex against various inputs |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
JeffreyCA
approved these changes
Mar 9, 2026
vhvb1989
approved these changes
Mar 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
azd pipeline configfails when the GitHub repo name contains dots (e.g.,my-org/my.app) because federated identity credential names only allow letters, numbers, hyphens, and underscores.Root Cause
github_provider.go:388only replaced/with-in the repo slug but dots and other special characters passed through.Fix
credentialNameSanitizerregex replaces all invalid charactersurl.PathEscape()wrappingTesting
Fixes #5948