Fixing race condition in ux.TaskList when accessing the completed count - #7076
Merged
richardpark-msft merged 1 commit intoMar 11, 2026
Merged
Conversation
richardpark-msft
requested review from
JeffreyCA,
hemarina,
rajeshkamal5050,
tg-msft,
vhvb1989,
wbreza and
weikanglim
as code owners
March 11, 2026 22:32
Contributor
There was a problem hiding this comment.
Pull request overview
Fixes a data race in the ux.TaskList render/update loop by making reads of the completed counter atomic, matching the existing atomic writes.
Changes:
- Replace non-atomic read of
t.completedwithatomic.LoadInt32inTaskList.isCompleted().
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
You can also share your feedback on Copilot code review. Take the survey.
vhvb1989
approved these changes
Mar 11, 2026
richardpark-msft
enabled auto-merge (squash)
March 11, 2026 22:50
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
jongio
pushed a commit
to jongio/azure-dev
that referenced
this pull request
Mar 18, 2026
…nt (Azure#7076) Just a little unprotected access to a variable. This should just happen if you run `go test -race` This is the test I used to repro it, but I'm unsure if you already have `-race` turned on in testing, etc... Let me know, I'll move this into the right spot. ```go package bug_test import ( "testing" "github.com/azure/azure-dev/cli/azd/pkg/ux" "github.com/stretchr/testify/require" ) func TestUseUXTaskList_RaceCondition(t *testing.T) { taskList := ux.NewTaskList(&ux.TaskListOptions{}) taskList.AddTask(ux.TaskOptions{ Title: "hello", Action: func(spf ux.SetProgressFunc) (ux.TaskState, error) { return ux.Success, nil }, }) taskList.AddTask(ux.TaskOptions{ Title: "hello2", Action: func(spf ux.SetProgressFunc) (ux.TaskState, error) { return ux.Success, nil }, }) err := taskList.Run() require.NoError(t, err) } ```
jongio
pushed a commit
to jongio/azure-dev
that referenced
this pull request
Mar 27, 2026
…nt (Azure#7076) Just a little unprotected access to a variable. This should just happen if you run `go test -race` This is the test I used to repro it, but I'm unsure if you already have `-race` turned on in testing, etc... Let me know, I'll move this into the right spot. ```go package bug_test import ( "testing" "github.com/azure/azure-dev/cli/azd/pkg/ux" "github.com/stretchr/testify/require" ) func TestUseUXTaskList_RaceCondition(t *testing.T) { taskList := ux.NewTaskList(&ux.TaskListOptions{}) taskList.AddTask(ux.TaskOptions{ Title: "hello", Action: func(spf ux.SetProgressFunc) (ux.TaskState, error) { return ux.Success, nil }, }) taskList.AddTask(ux.TaskOptions{ Title: "hello2", Action: func(spf ux.SetProgressFunc) (ux.TaskState, error) { return ux.Success, nil }, }) err := taskList.Run() require.NoError(t, err) } ```
jongio
pushed a commit
to jongio/azure-dev
that referenced
this pull request
Mar 27, 2026
…nt (Azure#7076) Just a little unprotected access to a variable. This should just happen if you run `go test -race` This is the test I used to repro it, but I'm unsure if you already have `-race` turned on in testing, etc... Let me know, I'll move this into the right spot. ```go package bug_test import ( "testing" "github.com/azure/azure-dev/cli/azd/pkg/ux" "github.com/stretchr/testify/require" ) func TestUseUXTaskList_RaceCondition(t *testing.T) { taskList := ux.NewTaskList(&ux.TaskListOptions{}) taskList.AddTask(ux.TaskOptions{ Title: "hello", Action: func(spf ux.SetProgressFunc) (ux.TaskState, error) { return ux.Success, nil }, }) taskList.AddTask(ux.TaskOptions{ Title: "hello2", Action: func(spf ux.SetProgressFunc) (ux.TaskState, error) { return ux.Success, nil }, }) err := taskList.Run() require.NoError(t, err) } ```
jongio
pushed a commit
to jongio/azure-dev
that referenced
this pull request
Mar 27, 2026
…nt (Azure#7076) Just a little unprotected access to a variable. This should just happen if you run `go test -race` This is the test I used to repro it, but I'm unsure if you already have `-race` turned on in testing, etc... Let me know, I'll move this into the right spot. ```go package bug_test import ( "testing" "github.com/azure/azure-dev/cli/azd/pkg/ux" "github.com/stretchr/testify/require" ) func TestUseUXTaskList_RaceCondition(t *testing.T) { taskList := ux.NewTaskList(&ux.TaskListOptions{}) taskList.AddTask(ux.TaskOptions{ Title: "hello", Action: func(spf ux.SetProgressFunc) (ux.TaskState, error) { return ux.Success, nil }, }) taskList.AddTask(ux.TaskOptions{ Title: "hello2", Action: func(spf ux.SetProgressFunc) (ux.TaskState, error) { return ux.Success, nil }, }) err := taskList.Run() require.NoError(t, err) } ```
jongio
pushed a commit
to jongio/azure-dev
that referenced
this pull request
Mar 27, 2026
…nt (Azure#7076) Just a little unprotected access to a variable. This should just happen if you run `go test -race` This is the test I used to repro it, but I'm unsure if you already have `-race` turned on in testing, etc... Let me know, I'll move this into the right spot. ```go package bug_test import ( "testing" "github.com/azure/azure-dev/cli/azd/pkg/ux" "github.com/stretchr/testify/require" ) func TestUseUXTaskList_RaceCondition(t *testing.T) { taskList := ux.NewTaskList(&ux.TaskListOptions{}) taskList.AddTask(ux.TaskOptions{ Title: "hello", Action: func(spf ux.SetProgressFunc) (ux.TaskState, error) { return ux.Success, nil }, }) taskList.AddTask(ux.TaskOptions{ Title: "hello2", Action: func(spf ux.SetProgressFunc) (ux.TaskState, error) { return ux.Success, nil }, }) err := taskList.Run() require.NoError(t, err) } ```
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Just a little unprotected access to a variable. This should just happen if you run
go test -raceThis is the test I used to repro it, but I'm unsure if you already have
-raceturned on in testing, etc... Let me know, I'll move this into the right spot.