test: fix unknown CI failures - #7714
Merged
weikanglim merged 1 commit intoApr 22, 2026
Merged
Conversation
weikanglim
marked this pull request as ready for review
April 14, 2026 18:26
weikanglim
requested review from
JeffreyCA,
hemarina,
jongio,
rajeshkamal5050,
tg-msft,
vhvb1989 and
wbreza
as code owners
April 14, 2026 18:26
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Fixes flaky CI “(unknown)” test failures by preventing interleaved/partial stdout from confusing go test -json/gotestsum output parsing, and by making generated Fig completion output consistently newline-terminated.
Changes:
- Add a shared captured test console helper that buffers stdout/stderr and only prints on test failure.
- Update repository interactive tests to use the captured console and
t.Context()instead of printing extra newlines to stdout. - Ensure
azd completion figemits a trailing newline; update testdata and tests accordingly.
Show a summary per file
| File | Description |
|---|---|
| cli/azd/internal/repository/test_console_test.go | Adds a buffered test console that only logs captured output on failure. |
| cli/azd/internal/repository/infra_confirm_test.go | Switches interactive tests to use the captured console and test context. |
| cli/azd/internal/repository/detect_confirm_test.go | Switches interactive tests to use the captured console and test context. |
| cli/azd/internal/repository/app_init_test.go | Switches interactive tests to use the captured console and test context. |
| cli/azd/cmd/testdata/TestFigSpec.ts | Adds trailing newline to keep generated spec output shell/test friendly. |
| cli/azd/cmd/completion_test.go | Captures command stdout and asserts the Fig spec content includes a trailing newline. |
| cli/azd/cmd/completion.go | Writes the Fig spec to stdout with Fprintln to enforce a trailing newline. |
Copilot's findings
- Files reviewed: 7/7 changed files
- Comments generated: 3
jongio
approved these changes
Apr 14, 2026
jongio
left a comment
jongio
left a comment
Member
There was a problem hiding this comment.
Two separate sources of gotestsum "unknown" failures, both fixed correctly.
The fmt.Fprintln change is exact - the TypeScript template doesn't end with a newline, so this adds precisely one. The snapshot update matches.
newCapturedTestConsole is the right call. Centralizing the setup removes three copies of boilerplate, captures output so it doesn't pollute parallel test output, and only surfaces it when a test actually fails. The t.Helper() is there, cleanup is conditional on failure - nothing to improve.
The removed fmt.Println() calls were load-bearing workarounds; they're no longer needed once output is captured. Good to see them gone.
JeffreyCA
approved these changes
Apr 14, 2026
hemarina
approved these changes
Apr 15, 2026
Contributor
|
/check-enforcer override |
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
1 similar comment
Member
Author
|
@copilot resolve the merge conflicts in this pull request |
Ensure `azd completion fig` ends with a trailing newline so gotestsum/JUnit does not turn a passing test into an `(unknown)` failure. Capture interactive console output in internal/repository tests and emit it only when a test fails, avoiding stdout interleaving like `=== FAIL: internal/repository TestInitializer_PromptIfNonEmpty (unknown)`. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
weikanglim
force-pushed
the
weikanglim/fix-unknown-ci-failures
branch
from
April 21, 2026 22:43
4e6c699 to
fcdec0f
Compare
JeffreyCA
approved these changes
Apr 21, 2026
weikanglim
enabled auto-merge (squash)
April 21, 2026 23:42
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
jongio
added a commit
that referenced
this pull request
Apr 22, 2026
… creds Test_CLI_Up_Down_ContainerApp_RemoteBuild_MultiService called recording.Start(t) before its skip check. recording.Start does t.Fatalf when the cassette is missing, so CI without cassettes AND without AZURE_TENANT_ID hard-failed instead of skipping. Fix: check cassette existence + AZURE_TENANT_ID before recording.Start, skip cleanly if both absent. Keep the original post-Start nil-session skip as defensive guard. (The companion completion_test.go phantom-failure fix from this same commit was superseded by upstream PR #7714 during rebase, which adds a trailing newline in the renderer plus stdout capture.) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
added a commit
that referenced
this pull request
Apr 23, 2026
… creds Test_CLI_Up_Down_ContainerApp_RemoteBuild_MultiService called recording.Start(t) before its skip check. recording.Start does t.Fatalf when the cassette is missing, so CI without cassettes AND without AZURE_TENANT_ID hard-failed instead of skipping. Fix: check cassette existence + AZURE_TENANT_ID before recording.Start, skip cleanly if both absent. Keep the original post-Start nil-session skip as defensive guard. (The companion completion_test.go phantom-failure fix from this same commit was superseded by upstream PR #7714 during rebase, which adds a trailing newline in the renderer plus stdout capture.) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
added a commit
that referenced
this pull request
Apr 27, 2026
… creds Test_CLI_Up_Down_ContainerApp_RemoteBuild_MultiService called recording.Start(t) before its skip check. recording.Start does t.Fatalf when the cassette is missing, so CI without cassettes AND without AZURE_TENANT_ID hard-failed instead of skipping. Fix: check cassette existence + AZURE_TENANT_ID before recording.Start, skip cleanly if both absent. Keep the original post-Start nil-session skip as defensive guard. (The companion completion_test.go phantom-failure fix from this same commit was superseded by upstream PR #7714 during rebase, which adds a trailing newline in the renderer plus stdout capture.) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
added a commit
that referenced
this pull request
Apr 30, 2026
… creds Test_CLI_Up_Down_ContainerApp_RemoteBuild_MultiService called recording.Start(t) before its skip check. recording.Start does t.Fatalf when the cassette is missing, so CI without cassettes AND without AZURE_TENANT_ID hard-failed instead of skipping. Fix: check cassette existence + AZURE_TENANT_ID before recording.Start, skip cleanly if both absent. Keep the original post-Start nil-session skip as defensive guard. (The companion completion_test.go phantom-failure fix from this same commit was superseded by upstream PR #7714 during rebase, which adds a trailing newline in the renderer plus stdout capture.) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
added a commit
that referenced
this pull request
Apr 30, 2026
… creds Test_CLI_Up_Down_ContainerApp_RemoteBuild_MultiService called recording.Start(t) before its skip check. recording.Start does t.Fatalf when the cassette is missing, so CI without cassettes AND without AZURE_TENANT_ID hard-failed instead of skipping. Fix: check cassette existence + AZURE_TENANT_ID before recording.Start, skip cleanly if both absent. Keep the original post-Start nil-session skip as defensive guard. (The companion completion_test.go phantom-failure fix from this same commit was superseded by upstream PR #7714 during rebase, which adds a trailing newline in the renderer plus stdout capture.) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
jongio
added a commit
that referenced
this pull request
May 2, 2026
… creds Test_CLI_Up_Down_ContainerApp_RemoteBuild_MultiService called recording.Start(t) before its skip check. recording.Start does t.Fatalf when the cassette is missing, so CI without cassettes AND without AZURE_TENANT_ID hard-failed instead of skipping. Fix: check cassette existence + AZURE_TENANT_ID before recording.Start, skip cleanly if both absent. Keep the original post-Start nil-session skip as defensive guard. (The companion completion_test.go phantom-failure fix from this same commit was superseded by upstream PR #7714 during rebase, which adds a trailing newline in the renderer plus stdout capture.) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
azd completion figalways writes a trailing newline so gotestsum/JUnit does not misparse passing test output as(unknown)failuresinternal/repositorytests and only emit it when a test failsProblem
CI has been surfacing bogus Unknown failures even when the underlying test passed, for example:
The failures were caused by test output interleaving with
go test -json/gotestsum markers.Testing
go test ./... -shortFixes #7731