fix: exempt Microsoft.Chaos/targets from reserved name preflight check#8240
Merged
Conversation
#8239) Azure Chaos Studio target names (e.g. microsoft-azurekubernetesservicechaosmesh) are service-mandated and cannot be renamed by users. ARM does not enforce the reserved-word rule on these resources, so the preflight warning was a false positive. Add Microsoft.Chaos/targets to azureReservedResourceNameExemptTypes and add corresponding test coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
Contributor
There was a problem hiding this comment.
Pull request overview
Note
Copilot was unable to run its full agentic suite in this review.
Exempts Microsoft.Chaos/targets from the reserved-name preflight warning to avoid false positives for Chaos Studio target resources whose names are service-mandated (Fixes #8239).
Changes:
- Added
Microsoft.Chaos/targetsto the reserved-name check exemption allowlist. - Extended tests to ensure the exemption applies to the exact type and child types via prefix matching, and that no warning is emitted end-to-end.
Reviewed changes
Copilot reviewed 2 out of 2 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cli/azd/pkg/infra/provisioning/bicep/bicep_provider.go |
Adds Microsoft.Chaos/targets to the exemption list used by the reserved-name preflight check. |
cli/azd/pkg/infra/provisioning/bicep/bicep_provider_reserved_names_test.go |
Adds unit + integration-style test coverage validating the exemption and suppression of warnings. |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
JeffreyCA
approved these changes
May 19, 2026
vhvb1989
marked this pull request as ready for review
May 19, 2026 01:02
vhvb1989
requested review from
hemarina,
jongio,
rajeshkamal5050,
tg-msft,
wbreza and
weikanglim
as code owners
May 19, 2026 01:02
wbreza
approved these changes
May 19, 2026
wbreza
left a comment
wbreza
left a comment
Contributor
There was a problem hiding this comment.
Reviewed the diff and existing context — LGTM. ✅
Summary of review:
- Exemption is added in the right place (�zureReservedResourceNameExemptTypes) and the new // Service-mandated names ... comment block is a nice taxonomy split from the prior "Convention-named" group.
- Matching semantics are correct: isReservedNameCheckExempt lower-cases and uses HasPrefix(... + "/"), so Microsoft.Chaos/targets, Microsoft.Chaos/targets/capabilities, and microsoft.chaos/targets are all covered as expected.
- Scope is appropriately narrow — limited to Microsoft.Chaos/targets, not broader patterns.
- Test coverage is thorough: end-to-end case in TestCheckReservedResourceNames plus three targeted cases in TestIsReservedNameCheckExempt (exact, child via prefix, case-insensitive).
- Copilot bot's only inline comment (case-insensitive coverage) was directly addressed in commit 3f297a4.
No new findings. Safe to merge.
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com>
vhvb1989
enabled auto-merge (squash)
May 19, 2026 18:13
Collaborator
Azure Dev CLI Install InstructionsInstall scriptsMacOS/Linux
bash: pwsh: WindowsPowerShell install MSI install Standalone Binary
MSI
Documentationlearn.microsoft.com documentationtitle: Azure Developer CLI reference
|
JeffreyCA
approved these changes
May 20, 2026
Copilot AI
pushed a commit
that referenced
this pull request
May 21, 2026
#8240) * fix: exempt Microsoft.Chaos/targets from reserved name preflight check (#8239) Azure Chaos Studio target names (e.g. microsoft-azurekubernetesservicechaosmesh) are service-mandated and cannot be renamed by users. ARM does not enforce the reserved-word rule on these resources, so the preflight warning was a false positive. Add Microsoft.Chaos/targets to azureReservedResourceNameExemptTypes and add corresponding test coverage. Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: add case-insensitive test for Chaos Studio exemption (iteration 1) Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> * fix: add cspell override for azurekubernetesservicechaosmesh Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> --------- Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Co-authored-by: therealjohn <1501196+therealjohn@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fixes #8239
Azure Chaos Studio target names (e.g.
microsoft-azurekubernetesservicechaosmesh) are service-mandated and cannot be renamed by users. ARM does not enforce the reserved-word rule onMicrosoft.Chaos/targets, so the preflight warning was a false positive that misleadingly claimed "The deployment will fail."Changes
Microsoft.Chaos/targetstoazureReservedResourceNameExemptTypesinbicep_provider.gobicep_provider_reserved_names_test.go:TestIsReservedNameCheckExempt: exact type + child type (capabilities) via prefix matchTestCheckReservedResourceNames: end-to-end resource entry confirming no warning is emitted