feat(errors): add ACR permission denied error handling and suggestions#8482
Merged
trangevi merged 2 commits intoMay 29, 2026
Merged
Conversation
feat(cspell): update cspell.yaml with new project-specific terms test: enhance tests for ACR permission guidance and error classification
therealjohn
requested review from
JeffreyCA,
trangevi and
trrwilson
as code owners
May 29, 2026 16:47
Contributor
There was a problem hiding this comment.
Pull request overview
This PR improves Azure AI Agents container publish error handling by distinguishing ACR RBAC/auth failures from private-network ACR failures and providing targeted remediation guidance.
Changes:
- Adds
acr_permission_deniedstructured error classification and user-facing ACR role assignment guidance. - Tightens private ACR network classification to avoid misclassifying RBAC failures.
- Expands tests for ACR permission/network classification and updates extension spell-check terms.
Reviewed changes
Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
cli/azd/extensions/azure.ai.agents/internal/project/service_target_agent.go |
Adds ACR permission classifier, remediation suggestion, shared ACR context signals, and regex parsing for ARM errors. |
cli/azd/extensions/azure.ai.agents/internal/project/service_target_agent_test.go |
Adds/updates tests for permission guidance, dynamic substitution, placeholder fallback, and non-ACR negative cases. |
cli/azd/extensions/azure.ai.agents/internal/exterrors/codes.go |
Registers the new acr_permission_denied error code. |
cli/azd/extensions/azure.ai.agents/cspell.yaml |
Adds project-specific terms used by the new error matching and tests. |
trangevi
approved these changes
May 29, 2026
trangevi
enabled auto-merge (squash)
May 29, 2026 17:13
Member
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
feat(cspell): update cspell.yaml with new project-specific terms
test: enhance tests for ACR permission guidance and error classification
Fixes #8483