Skip to content

feat(errors): add ACR permission denied error handling and suggestions#8482

Merged
trangevi merged 2 commits into
Azure:mainfrom
therealjohn:jm/agent-acr-permission-suggestion
May 29, 2026
Merged

feat(errors): add ACR permission denied error handling and suggestions#8482
trangevi merged 2 commits into
Azure:mainfrom
therealjohn:jm/agent-acr-permission-suggestion

Conversation

@therealjohn

@therealjohn therealjohn commented May 29, 2026

Copy link
Copy Markdown
Contributor

feat(cspell): update cspell.yaml with new project-specific terms
test: enhance tests for ACR permission guidance and error classification

Fixes #8483

feat(cspell): update cspell.yaml with new project-specific terms
test: enhance tests for ACR permission guidance and error classification

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR improves Azure AI Agents container publish error handling by distinguishing ACR RBAC/auth failures from private-network ACR failures and providing targeted remediation guidance.

Changes:

  • Adds acr_permission_denied structured error classification and user-facing ACR role assignment guidance.
  • Tightens private ACR network classification to avoid misclassifying RBAC failures.
  • Expands tests for ACR permission/network classification and updates extension spell-check terms.

Reviewed changes

Copilot reviewed 4 out of 4 changed files in this pull request and generated 1 comment.

File Description
cli/azd/extensions/azure.ai.agents/internal/project/service_target_agent.go Adds ACR permission classifier, remediation suggestion, shared ACR context signals, and regex parsing for ARM errors.
cli/azd/extensions/azure.ai.agents/internal/project/service_target_agent_test.go Adds/updates tests for permission guidance, dynamic substitution, placeholder fallback, and non-ACR negative cases.
cli/azd/extensions/azure.ai.agents/internal/exterrors/codes.go Registers the new acr_permission_denied error code.
cli/azd/extensions/azure.ai.agents/cspell.yaml Adds project-specific terms used by the new error matching and tests.

@github-actions github-actions Bot added the ext-agents azure.ai.agents extension label May 29, 2026
@trangevi
trangevi enabled auto-merge (squash) May 29, 2026 17:13
@trangevi

Copy link
Copy Markdown
Member

/check-enforcer override

@trangevi
trangevi merged commit 0316fca into Azure:main May 29, 2026
26 of 27 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

ext-agents azure.ai.agents extension

Projects

None yet

Development

Successfully merging this pull request may close these issues.

feat(azure.ai.agents): improve ACR permission denied error with code (zip) deploy guidance

3 participants