Normalize connection auth AgenticIdentity to ARM-required AgenticIdentityToken#8512
Merged
Conversation
Co-authored-by: trangevi <26490000+trangevi@users.noreply.github.com>
Co-authored-by: trangevi <26490000+trangevi@users.noreply.github.com>
Copilot
AI
changed the title
[WIP] Fix AgenticIdentityToken acceptance for connection auth
Normalize connection auth Jun 1, 2026
AgenticIdentity to ARM-required AgenticIdentityToken
trangevi
marked this pull request as ready for review
June 1, 2026 17:36
trangevi
requested review from
JeffreyCA,
glharper,
therealjohn and
trrwilson
as code owners
June 1, 2026 17:36
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
glharper
approved these changes
Jun 1, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR addresses a compatibility gap where agent.yaml allowed AgenticIdentity, but ARM connection provisioning requires AgenticIdentityToken, by accepting both inputs while normalizing emitted/provisioned connection auth types to the ARM-compatible value.
Changes:
- Extended the JSON schema
authTypeenum and audience description to includeAgenticIdentityToken. - Added
NormalizeConnectionAuthTypeto canonicalize legacyAgenticIdentity→AgenticIdentityToken. - Applied auth-type normalization when extracting toolbox-derived tool connections and manifest connection resources, with accompanying unit tests.
Reviewed changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 2 comments.
Show a summary per file
| File | Description |
|---|---|
| cli/azd/extensions/azure.ai.agents/schemas/azure.ai.agent.json | Adds AgenticIdentityToken to the Connection.authType enum and updates audience description. |
| cli/azd/extensions/azure.ai.agents/internal/pkg/agents/agent_yaml/yaml.go | Introduces AuthTypeAgenticIdentityToken and normalization helper for provisioning compatibility. |
| cli/azd/extensions/azure.ai.agents/internal/pkg/agents/agent_yaml/yaml_test.go | Adds unit test coverage for NormalizeConnectionAuthType. |
| cli/azd/extensions/azure.ai.agents/internal/pkg/agents/agent_yaml/parse_test.go | Extends auth-type coverage test cases to include AgenticIdentityToken. |
| cli/azd/extensions/azure.ai.agents/internal/cmd/init.go | Normalizes auth types when extracting toolbox tool connections and connection resources. |
| cli/azd/extensions/azure.ai.agents/internal/cmd/init_test.go | Adds tests asserting auth-type normalization during extraction. |
Co-authored-by: Copilot Autofix powered by AI <175728472+Copilot@users.noreply.github.com>
Co-authored-by: trangevi <26490000+trangevi@users.noreply.github.com>
glharper
approved these changes
Jun 1, 2026
trangevi
enabled auto-merge (squash)
June 1, 2026 17:53
Member
|
/check-enforcer override |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
agent.yamlallowedAgenticIdentity, but ARM connection provisioning only acceptsAgenticIdentityToken, creating a validation/provisioning dead end. This change makes both values accepted in config while ensuring generated provisioning config uses the ARM-compatible value.Schema compatibility
AgenticIdentityTokentoschemas/azure.ai.agent.jsonauthTypeenum.audiencefield description to includeAgenticIdentityToken.Provisioning normalization
NormalizeConnectionAuthTypeinagent_yamlto canonicalize legacyAgenticIdentitytoAgenticIdentityToken.credentials.typefallback whenauthTypeis omittedBackward compatibility intent
AgenticIdentityaccepted as input for existing manifests.AgenticIdentityTokenfor management-plane connection creation paths.