fix: prevent duplicate service target providers#8901
Merged
Conversation
huimiu
marked this pull request as ready for review
July 1, 2026 02:33
huimiu
requested review from
JeffreyCA,
RickWinter,
glharper,
hemarina,
hund030,
tg-msft,
therealjohn,
trangevi,
trrwilson and
vhvb1989
as code owners
July 1, 2026 02:33
Contributor
There was a problem hiding this comment.
Pull request overview
This PR tightens extension registry correctness by removing outdated service-target provider declarations from azure.ai.agents and adding validation to prevent duplicate service-target providers across the latest versions of extensions.
Changes:
- Removed
azure.ai.project,azure.ai.connection, andazure.ai.toolboxservice-target provider entries fromazure.ai.agentsto avoid conflicts with split Foundry extensions. - Added registry-level validation to detect duplicate service-target providers across latest extension versions (case-insensitive), including duplicates within a single extension’s latest version.
- Added unit tests covering both cross-extension and within-extension duplicate provider scenarios.
Reviewed changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| cli/azd/pkg/extensions/validate_registry.go | Adds a registry validation pass to reject duplicate latest-version service-target providers. |
| cli/azd/pkg/extensions/validate_registry_test.go | Adds test coverage for duplicate provider detection across extensions and within one latest version. |
| cli/azd/extensions/azure.ai.agents/extension.yaml | Removes service-target provider claims that belong to other split Foundry extensions. |
trangevi
approved these changes
Jul 1, 2026
📋 Prioritization NoteThanks for the contribution! The linked issue isn't in the current milestone yet. |
vhvb1989
approved these changes
Jul 1, 2026
Member
Author
|
/check-enforcer override |
JeffreyCA
added a commit
to JeffreyCA/azure-dev
that referenced
this pull request
Jul 9, 2026
Guard against provider drift (see Azure#8901/Azure#8902): - pkg/extensions: reject invalid provider types, providers missing their required capability, and any provider owned by >1 extension; runs in ext-registry-ci on registry.json and extension.yaml changes. - azdext.VerifyProvidersMatchManifest: assert Go registrations match the manifest, with tests for demo/agents/connections/routines/toolboxes and a meta-test requiring the check on every provider-bearing extension (projects/skills allowlisted pending an SDK bump). - Fix schema/Go drift: add the provisioning-provider type to extension.schema.json + ValidProviderTypes, guarded by a sync test.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
azure.ai.agentsfor hosts owned by the split Foundry extensions.Fixes #8902
Validation