Skip to content

Fixes #77: Corrected command hint in github login error message#92

Merged
ellismg merged 1 commit into
Azure:mainfrom
TheEskhaton:fix-77
Jul 13, 2022
Merged

Fixes #77: Corrected command hint in github login error message#92
ellismg merged 1 commit into
Azure:mainfrom
TheEskhaton:fix-77

Conversation

@TheEskhaton

@TheEskhaton TheEskhaton commented Jul 13, 2022

Copy link
Copy Markdown
Contributor

Hi!

Took the liberty to do this fix while familiarizing myself with the azd code.

@check-enforcer

Copy link
Copy Markdown

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override

@ellismg

ellismg commented Jul 13, 2022

Copy link
Copy Markdown
Member

/azp run azure-dev - cli

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines successfully started running 1 pipeline(s).

@jongio jongio added this to the Next milestone Jul 13, 2022
@azure-sdk

Copy link
Copy Markdown
Collaborator

Azure Dev CLI Install Instructions

Install scripts

MacOS/Linux

May elevate using sudo on some platforms and configurations

curl -fsSL https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/92/uninstall-azd.sh | bash;
curl -fsSL https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/92/install-azd.sh | bash -s -- --base-url https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/92 --version '' --verbose

Windows

powershell -c "Set-ExecutionPolicy Bypass Process; irm 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/92/uninstall-azd.ps1' > uninstall-azd.ps1; ./uninstall-azd.ps1;"
powershell -c "Set-ExecutionPolicy Bypass Process; irm 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/92/install-azd.ps1' > install-azd.ps1; ./install-azd.ps1 -BaseUrl 'https://azuresdkreleasepreview.blob.core.windows.net/azd/standalone/pr/92' -Version '' -Verbose;"

Standalone Binary

Container

docker run -it azdevcliextacr.azurecr.io/azure-dev:pr-92

@jongio

jongio commented Jul 13, 2022

Copy link
Copy Markdown
Member

Thanks @TheEskhaton !

@ellismg

ellismg commented Jul 13, 2022

Copy link
Copy Markdown
Member

Thanks, @TheEskhaton - We'll merge this a little later today - I'll push a follow up change after that adds this to the CHANGELOG.md and calls you out as an external contributor. Thanks for the improvement!

@ellismg ellismg self-assigned this Jul 13, 2022
@ellismg
ellismg merged commit 6745191 into Azure:main Jul 13, 2022
ellismg added a commit to ellismg/azure-dev that referenced this pull request Jul 13, 2022
ellismg added a commit to ellismg/azure-dev that referenced this pull request Jul 13, 2022
ellismg added a commit that referenced this pull request Jul 13, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants