Add auxiliary authorization support for Azure cross tenant. - #884
Merged
Conversation
yaohaizh
force-pushed
the
auxiliary_tokens
branch
from
November 4, 2019 02:13
81252df to
fbb5e77
Compare
jianghaolu
reviewed
Nov 4, 2019
|
|
||
| @SuppressWarnings("unchecked") | ||
| @Override | ||
| public T withAuxiliaryTokens(AzureTokenCredentials... tokens) { |
Contributor
There was a problem hiding this comment.
Should this be named withAuxiliaryCredentials(AzureTokenCredentials... credentials)?
jianghaolu
reviewed
Nov 4, 2019
|
|
||
| @Override | ||
| public Response intercept(Chain chain) throws IOException { | ||
| if (this.tokens == null || this.tokens.length == 0) { |
Contributor
There was a problem hiding this comment.
Can we try chain.proceed(chain.request() first and only authenticate the auxiliary credentials if a certain error comes back? This will avoid unnecessary network calls for method calls not requiring auxiliary tokens.
Author
There was a problem hiding this comment.
Fixed. LinkedAuthorizationFailed will throw at the first spot.
Author
|
@jianghaolu thanks, resolved the review feedback. |
yaohaizh
force-pushed
the
auxiliary_tokens
branch
from
November 6, 2019 04:47
020c8af to
57de4de
Compare
jianghaolu
approved these changes
Nov 6, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.