Skip to content

Update role assignment cmdlet - #12570

Merged
isra-fel merged 40 commits into
Azure:masterfrom
dagoroz:UpdateRoleAssignmentCMDlet
Aug 11, 2020
Merged

Update role assignment cmdlet#12570
isra-fel merged 40 commits into
Azure:masterfrom
dagoroz:UpdateRoleAssignmentCMDlet

Conversation

@dagoroz

@dagoroz dagoroz commented Aug 4, 2020

Copy link
Copy Markdown
Contributor

Description

Added cmdlet "Set-AzRoleAssignment" and small suggestions that arose from the design review

Checklist

  • I have read the Submitting Changes section of CONTRIBUTING.md
  • The title of the PR is clear and informative
  • The appropriate ChangeLog.md file(s) has been updated:
    • For any service, the ChangeLog.md file can be found at src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md
    • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header -- no new version header should be added
  • The PR does not introduce breaking changes
  • x] If applicable, the changes made in the PR have proper test coverage
  • For public API changes to cmdlets:
    • a cmdlet design review was approved for the changes in this repository (Microsoft internal only)
    • the markdown help files have been regenerated using the commands listed here

Link to review

https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/689

@adxsdkps

adxsdkps commented Aug 4, 2020

Copy link
Copy Markdown
Collaborator

Can one of the admins verify this patch?

@isra-fel isra-fel self-assigned this Aug 5, 2020
Comment thread src/Resources/Resources/RoleAssignments/SetAzureRoleAssignmentCommand.cs Outdated
Comment thread src/Resources/Resources/RoleAssignments/SetAzureRoleAssignmentCommand.cs Outdated
Comment thread src/Resources/Resources/help/Az.Resources.md Outdated
@jiasli

jiasli commented Aug 6, 2020

Copy link
Copy Markdown

Could you update the New-AzRoleAssignment.md and also add Set-AzRoleAssignment.md to provide more examples on the updated commands?

@isra-fel isra-fel left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @dagoroz , please CIL.
BTW the help file Set-AzRoleAssignment.md is missing.

Thanks

Comment thread src/Resources/Resources/ChangeLog.md Outdated
Comment thread src/Resources/Resources/RoleAssignments/NewAzureRoleAssignmentCommand.cs Outdated
Comment thread src/Resources/Resources/RoleAssignments/SetAzureRoleAssignmentCommand.cs Outdated
Comment thread src/Resources/Resources/RoleAssignments/SetAzureRoleAssignmentCommand.cs Outdated
dagoroz and others added 6 commits August 6, 2020 09:52
…Command.cs

Co-authored-by: Jiashuo Li <jiasli@microsoft.com>
…Command.cs

Co-authored-by: Jiashuo Li <jiasli@microsoft.com>
Co-authored-by: Jiashuo Li <jiasli@microsoft.com>
Co-authored-by: Yeming Liu <felix_liu@outlook.com>
@isra-fel

Copy link
Copy Markdown
Member

Hi @dagoroz , only thing left is to regenerate help docs: https://github.com/Azure/azure-powershell/blob/master/documentation/development-docs/help-generation.md#updating-help-after-making-cmdlet-changes

Some of the changes were not reflected in docs, for example there should be description of -WhatIf parameter in Set-AzRoleAssignment.md

@isra-fel
isra-fel merged commit 95ecddb into Azure:master Aug 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants