Revert "Pass principal type during role assignment put operations" - #14103
Closed
dagoroz wants to merge 8 commits into
Closed
Revert "Pass principal type during role assignment put operations"#14103dagoroz wants to merge 8 commits into
dagoroz wants to merge 8 commits into
Conversation
Collaborator
|
Hi @dagoroz , any particular reason this need to be reverted? |
Member
|
LGTM except changelog. I prefer that you just explain the change you did. For instance, removed (past tense is recommended) principal type on New-AzRoleAssignment and Set-AzRoleAssignment because …. (if there is any reason) |
…zure/azure-powershell into revert-13590-passPrincipalType
Contributor
Author
|
@VeryEarly added you to the email thread |
Collaborator
|
/azp run |
Contributor
|
Azure Pipelines successfully started running 3 pipeline(s). |
Collaborator
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reverts #13590