Skip to content

Fixes/simplifications - #29984

Draft
Alex Estevez (AEst2002) wants to merge 1 commit into
Azure:copilot/az-compute-future-capacity-reservationfrom
AEst2002:copilot/az-compute-future-capacity-reservation
Draft

Fixes/simplifications#29984
Alex Estevez (AEst2002) wants to merge 1 commit into
Azure:copilot/az-compute-future-capacity-reservationfrom
AEst2002:copilot/az-compute-future-capacity-reservation

Conversation

@AEst2002

Copy link
Copy Markdown
Member

Description

  • Removed -MinimumCommitmentDays and -ScheduleProfileStart parameters and associated logic from UpdateAzCapacityReservationCommand as updating an FCR is not supported for now.
  • Removed error logic for -MinimumCommitmentDays and -ScheduleProfileStart in NewAzCapacityReservationCommand as these validations relied on values configured by CRP which are still subject to change. Instead, we want to rely on the service for any errors.
  • Adjusted test logic to reflect the above
  • Minor summary/description edits for accuracy/specificity.

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • Update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Contributor
Azure Pipelines:
Successfully started running 3 pipeline(s).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants