Migrate Fleet module to tsp - #29997
Draft
JunKai-v wants to merge 1 commit into
Draft
Conversation
Contributor
|
Azure Pipelines: Successfully started running 1 pipeline(s). There may be pipelines that require an authorized user to comment /azp run to run. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR migrates the Az.Fleet AutoRest module generation workflow to TypeSpec (tsp) and updates the Fleet module surface area accordingly (new resources/cmdlets, updated API version, refreshed help/test scaffolding).
Changes:
- Introduces TypeSpec configuration (
tspconfig.yaml,tsp-location.yaml) and updates UX resource definitions to API version2026-06-01. - Expands the module manifest exports and adds/updates help/docs for new Fleet sub-resources (gates, managedNamespaces, autoUpgradeProfiles) and new operations (e.g., Skip-AzFleetUpdateRun).
- Adds new Pester test and example markdown files (currently largely placeholder/stub content).
Reviewed changes
Copilot reviewed 113 out of 113 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/Fleet/Fleet/help/Update-AzFleetUpdateStrategy.md | Help text tweak (SubscriptionId guidance). |
| src/Fleet/Fleet/help/Update-AzFleetUpdateRun.md | Help content/parameter doc updates for UpdateRun. |
| src/Fleet/Fleet/help/Update-AzFleetMember.md | Help updates (new Label param, SubscriptionId note). |
| src/Fleet/Fleet/help/Update-AzFleetManagedNamespace.md | New help file for managedNamespaces update cmdlet. |
| src/Fleet/Fleet/help/Update-AzFleet.md | Help updates for Fleet update cmdlet. |
| src/Fleet/Fleet/help/Stop-AzFleetUpdateRun.md | Help text tweak (SubscriptionId guidance). |
| src/Fleet/Fleet/help/Start-AzFleetUpdateRun.md | Help text tweak (SubscriptionId guidance). |
| src/Fleet/Fleet/help/Remove-AzFleetUpdateStrategy.md | Help text tweak (SubscriptionId guidance). |
| src/Fleet/Fleet/help/Remove-AzFleetUpdateRun.md | Help text tweak (SubscriptionId guidance). |
| src/Fleet/Fleet/help/Remove-AzFleetMember.md | Help text tweak (SubscriptionId guidance). |
| src/Fleet/Fleet/help/Remove-AzFleetManagedNamespace.md | New help file for managedNamespaces removal cmdlet. |
| src/Fleet/Fleet/help/Remove-AzFleetAutoUpgradeProfile.md | New help file for autoUpgradeProfiles removal cmdlet. |
| src/Fleet/Fleet/help/Remove-AzFleet.md | Help text tweak (SubscriptionId guidance). |
| src/Fleet/Fleet/help/New-AzFleetUpdateStrategy.md | Help updates for UpdateStrategy creation parameter sets. |
| src/Fleet/Fleet/help/New-AzFleetUpdateStageObject.md | Help updates for model helper (gates/maxConcurrency). |
| src/Fleet/Fleet/help/New-AzFleetUpdateRun.md | Help updates for UpdateRun creation parameters. |
| src/Fleet/Fleet/help/New-AzFleetUpdateGroupObject.md | Help updates for model helper (gates/maxConcurrency). |
| src/Fleet/Fleet/help/New-AzFleetMember.md | Help updates for FleetMember creation parameters (Label). |
| src/Fleet/Fleet/help/New-AzFleetAutoUpgradeProfileOperationUpdateRun.md | New help file for auto-upgrade “generate run” operation. |
| src/Fleet/Fleet/help/New-AzFleet.md | Help updates for Fleet creation parameters. |
| src/Fleet/Fleet/help/Get-AzFleetUpdateStrategy.md | Help updates (paging params, SubscriptionId note). |
| src/Fleet/Fleet/help/Get-AzFleetUpdateRun.md | Help updates (paging params, SubscriptionId note). |
| src/Fleet/Fleet/help/Get-AzFleetOperation.md | New help file for provider operations listing. |
| src/Fleet/Fleet/help/Get-AzFleetMember.md | Help updates (filter/paging params, SubscriptionId note). |
| src/Fleet/Fleet/help/Get-AzFleetManagedNamespace.md | New help file for managedNamespaces get cmdlet. |
| src/Fleet/Fleet/help/Get-AzFleetGate.md | New help file for gates get cmdlet. |
| src/Fleet/Fleet/help/Get-AzFleetCredentials.md | Help text tweak (SubscriptionId guidance). |
| src/Fleet/Fleet/help/Get-AzFleetAutoUpgradeProfile.md | New help file for autoUpgradeProfiles get cmdlet. |
| src/Fleet/Fleet/help/Get-AzFleet.md | Help updates (paging params, parameter set headings). |
| src/Fleet/Fleet/help/Az.Fleet.md | Module landing page updated with new cmdlets. |
| src/Fleet/Fleet/Az.Fleet.psd1 | Manifest regenerated: exports expanded, Az.Accounts min version updated. |
| src/Fleet/Fleet.Autorest/UX/Microsoft.ContainerService/fleets.json | UX API version bump to 2026-06-01. |
| src/Fleet/Fleet.Autorest/UX/Microsoft.ContainerService/fleets-updateStrategies.json | UX API version bump to 2026-06-01. |
| src/Fleet/Fleet.Autorest/UX/Microsoft.ContainerService/fleets-updateRuns.json | UX API version bump to 2026-06-01. |
| src/Fleet/Fleet.Autorest/UX/Microsoft.ContainerService/fleets-members.json | UX API version bump to 2026-06-01. |
| src/Fleet/Fleet.Autorest/UX/Microsoft.ContainerService/fleets-managedNamespaces.json | New UX definition for managedNamespaces commands. |
| src/Fleet/Fleet.Autorest/UX/Microsoft.ContainerService/fleets-gates.json | New UX definition for gates commands. |
| src/Fleet/Fleet.Autorest/UX/Microsoft.ContainerService/fleets-autoUpgradeProfiles.json | New UX definition for autoUpgradeProfiles commands. |
| src/Fleet/Fleet.Autorest/tspconfig.yaml | New TypeSpec PowerShell emitter configuration + directives. |
| src/Fleet/Fleet.Autorest/tsp-location.yaml | Spec repo/commit pin for TypeSpec input location. |
| src/Fleet/Fleet.Autorest/test/Update-AzFleetManagedNamespace.Tests.ps1 | New (skipped) Pester stubs for Update-AzFleetManagedNamespace. |
| src/Fleet/Fleet.Autorest/test/Update-AzFleetGate.Tests.ps1 | New (skipped) Pester stubs for Update-AzFleetGate. |
| src/Fleet/Fleet.Autorest/test/Update-AzFleetAutoUpgradeProfile.Tests.ps1 | New (skipped) Pester stubs for Update-AzFleetAutoUpgradeProfile. |
| src/Fleet/Fleet.Autorest/test/Skip-AzFleetUpdateRun.Tests.ps1 | New (skipped) Pester stubs for Skip-AzFleetUpdateRun. |
| src/Fleet/Fleet.Autorest/test/Remove-AzFleetManagedNamespace.Tests.ps1 | New (skipped) Pester stubs for Remove-AzFleetManagedNamespace. |
| src/Fleet/Fleet.Autorest/test/Remove-AzFleetAutoUpgradeProfile.Tests.ps1 | New (skipped) Pester stubs for Remove-AzFleetAutoUpgradeProfile. |
| src/Fleet/Fleet.Autorest/test/New-AzFleetManagedNamespace.Tests.ps1 | New (skipped) Pester stubs for New-AzFleetManagedNamespace. |
| src/Fleet/Fleet.Autorest/test/New-AzFleetAutoUpgradeProfileOperationUpdateRun.Tests.ps1 | New (skipped) Pester stubs for operation cmdlet. |
| src/Fleet/Fleet.Autorest/test/New-AzFleetAutoUpgradeProfile.Tests.ps1 | New (skipped) Pester stubs for New-AzFleetAutoUpgradeProfile. |
| src/Fleet/Fleet.Autorest/test/Get-AzFleetOperation.Tests.ps1 | New (skipped) Pester stubs for Get-AzFleetOperation. |
| src/Fleet/Fleet.Autorest/test/Get-AzFleetManagedNamespace.Tests.ps1 | New (skipped) Pester stubs for Get-AzFleetManagedNamespace. |
| src/Fleet/Fleet.Autorest/test/Get-AzFleetGate.Tests.ps1 | New (skipped) Pester stubs for Get-AzFleetGate. |
| src/Fleet/Fleet.Autorest/test/Get-AzFleetAutoUpgradeProfile.Tests.ps1 | New (skipped) Pester stubs for Get-AzFleetAutoUpgradeProfile. |
| src/Fleet/Fleet.Autorest/resources/README.md | Adds repo-only resources folder documentation. |
| src/Fleet/Fleet.Autorest/README.md | Removes old AutoRest YAML config section. |
| src/Fleet/Fleet.Autorest/Properties/AssemblyInfo.cs | New AssemblyInfo for Fleet.Autorest build. |
| src/Fleet/Fleet.Autorest/generate-info.json | Regeneration marker updated. |
| src/Fleet/Fleet.Autorest/examples/Update-AzFleetManagedNamespace.md | New placeholder example content. |
| src/Fleet/Fleet.Autorest/examples/Update-AzFleetGate.md | New placeholder example content. |
| src/Fleet/Fleet.Autorest/examples/Update-AzFleetAutoUpgradeProfile.md | New placeholder example content. |
| src/Fleet/Fleet.Autorest/examples/Skip-AzFleetUpdateRun.md | New placeholder example content. |
| src/Fleet/Fleet.Autorest/examples/Remove-AzFleetManagedNamespace.md | New placeholder example content. |
| src/Fleet/Fleet.Autorest/examples/Remove-AzFleetAutoUpgradeProfile.md | New placeholder example content. |
| src/Fleet/Fleet.Autorest/examples/New-AzFleetManagedNamespace.md | New placeholder example content. |
| src/Fleet/Fleet.Autorest/examples/New-AzFleetAutoUpgradeProfileOperationUpdateRun.md | New placeholder example content. |
| src/Fleet/Fleet.Autorest/examples/New-AzFleetAutoUpgradeProfile.md | New placeholder example content. |
| src/Fleet/Fleet.Autorest/examples/Get-AzFleetOperation.md | New placeholder example content. |
| src/Fleet/Fleet.Autorest/examples/Get-AzFleetManagedNamespace.md | New placeholder example content. |
| src/Fleet/Fleet.Autorest/examples/Get-AzFleetGate.md | New placeholder example content. |
| src/Fleet/Fleet.Autorest/examples/Get-AzFleetAutoUpgradeProfile.md | New placeholder example content. |
| src/Fleet/Fleet.Autorest/docs/Update-AzFleetUpdateStrategy.md | Generated docs update (SubscriptionId guidance). |
| src/Fleet/Fleet.Autorest/docs/Update-AzFleetUpdateRun.md | Generated docs update for UpdateRun. |
| src/Fleet/Fleet.Autorest/docs/Update-AzFleetMember.md | Generated docs update for FleetMember. |
| src/Fleet/Fleet.Autorest/docs/Update-AzFleetManagedNamespace.md | New generated docs for managedNamespaces update. |
| src/Fleet/Fleet.Autorest/docs/Update-AzFleet.md | Generated docs update for Fleet update. |
| src/Fleet/Fleet.Autorest/docs/Stop-AzFleetUpdateRun.md | Generated docs update (SubscriptionId guidance). |
| src/Fleet/Fleet.Autorest/docs/Start-AzFleetUpdateRun.md | Generated docs update (SubscriptionId guidance). |
| src/Fleet/Fleet.Autorest/docs/Remove-AzFleetUpdateStrategy.md | Generated docs update (SubscriptionId guidance). |
| src/Fleet/Fleet.Autorest/docs/Remove-AzFleetUpdateRun.md | Generated docs update (SubscriptionId guidance). |
| src/Fleet/Fleet.Autorest/docs/Remove-AzFleetMember.md | Generated docs update (SubscriptionId guidance). |
| src/Fleet/Fleet.Autorest/docs/Remove-AzFleetManagedNamespace.md | New generated docs for managedNamespaces removal. |
| src/Fleet/Fleet.Autorest/docs/Remove-AzFleetAutoUpgradeProfile.md | New generated docs for autoUpgradeProfiles removal. |
| src/Fleet/Fleet.Autorest/docs/Remove-AzFleet.md | Generated docs update (SubscriptionId guidance). |
| src/Fleet/Fleet.Autorest/docs/New-AzFleetUpdateStrategy.md | Generated docs update for UpdateStrategy create. |
| src/Fleet/Fleet.Autorest/docs/New-AzFleetUpdateStageObject.md | Generated docs update for model helper. |
| src/Fleet/Fleet.Autorest/docs/New-AzFleetUpdateRun.md | Generated docs update for UpdateRun create. |
| src/Fleet/Fleet.Autorest/docs/New-AzFleetUpdateGroupObject.md | Generated docs update for model helper. |
| src/Fleet/Fleet.Autorest/docs/New-AzFleetMember.md | Generated docs update for FleetMember create. |
| src/Fleet/Fleet.Autorest/docs/New-AzFleetAutoUpgradeProfileOperationUpdateRun.md | New generated docs for operation cmdlet. |
| src/Fleet/Fleet.Autorest/docs/New-AzFleet.md | Generated docs update for Fleet create. |
| src/Fleet/Fleet.Autorest/docs/Get-AzFleetUpdateStrategy.md | Generated docs update (paging params). |
| src/Fleet/Fleet.Autorest/docs/Get-AzFleetUpdateRun.md | Generated docs update (paging params). |
| src/Fleet/Fleet.Autorest/docs/Get-AzFleetOperation.md | New generated docs for provider operations listing. |
| src/Fleet/Fleet.Autorest/docs/Get-AzFleetMember.md | Generated docs update (filter/paging params). |
| src/Fleet/Fleet.Autorest/docs/Get-AzFleetManagedNamespace.md | New generated docs for managedNamespaces get. |
| src/Fleet/Fleet.Autorest/docs/Get-AzFleetGate.md | New generated docs for gates get. |
| src/Fleet/Fleet.Autorest/docs/Get-AzFleetCredentials.md | Generated docs update (SubscriptionId guidance). |
| src/Fleet/Fleet.Autorest/docs/Get-AzFleetAutoUpgradeProfile.md | New generated docs for autoUpgradeProfiles get. |
| src/Fleet/Fleet.Autorest/docs/Get-AzFleet.md | Generated docs update (paging params). |
| src/Fleet/Fleet.Autorest/docs/Az.Fleet.md | Generated module landing page update. |
| src/Fleet/Fleet.Autorest/custom/autogen-model-cmdlets/New-AzFleetUpdateStageObject.ps1 | Model cmdlet updated for gates/maxConcurrency. |
| src/Fleet/Fleet.Autorest/custom/autogen-model-cmdlets/New-AzFleetUpdateGroupObject.ps1 | Model cmdlet updated for gates/maxConcurrency. |
Suppressed comments (1)
src/Fleet/Fleet/help/New-AzFleetAutoUpgradeProfileOperationUpdateRun.md:37
- DESCRIPTION repeats the same grammar issue as SYNOPSIS ("Generates an generate run..."). Please rephrase so it's readable and correct.
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+1
to
+15
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the MIT License. See License.txt in the project root for license information. | ||
| // Changes may cause incorrect behavior and will be lost if the code is regenerated. | ||
| // Copyright (c) Microsoft Corporation. All rights reserved. | ||
| // Licensed under the Apache License, Version 2.0 (the ""License""); | ||
| // you may not use this file except in compliance with the License. | ||
| // You may obtain a copy of the License at | ||
| // http://www.apache.org/licenses/LICENSE-2.0 | ||
| // Unless required by applicable law or agreed to in writing, software | ||
| // distributed under the License is distributed on an ""AS IS"" BASIS, | ||
| // WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. | ||
| // See the License for the specific language governing permissions and | ||
| // limitations under the License. | ||
| // Code generated by Microsoft (R) AutoRest Code Generator.Changes may cause incorrect behavior and will be lost if the code | ||
| // is regenerated. |
Comment on lines
305
to
+306
| (since 2023-08-15-preview)Setting both "updateStrategyId" and "strategy" is invalid.UpdateRuns created by "updateStrategyId" snapshot the referenced UpdateStrategy at the time of creation and store it in the "strategy" field. | ||
| Subsequent changes to the referenced FleetUpdateStrategy resource do not propagate. | ||
| UpdateRunStrategy changes can be made directly on the "strategy" field before launching the UpdateRun. | ||
| Subsequent changes to the referenced FleetUpdateStrategy resource do not propagate.UpdateRunStrategy changes can be made directly on the "strategy" field before launching the UpdateRun. |
Comment on lines
335
to
+336
| ### -UpgradeType | ||
| The upgrade type.Full requires the KubernetesVersion property to be set.NodeImageOnly requires the KubernetesVersion property not to be set. | ||
| ManagedClusterUpgradeType is the type of upgrade to be applied. |
Comment on lines
304
to
307
| ### -SubscriptionId | ||
| The ID of the target subscription. | ||
| The value must be an UUID. | ||
|
|
Comment on lines
+43
to
+65
| ## EXAMPLES | ||
|
|
||
| ### Example 1: {{ Add title here }} | ||
| ```powershell | ||
| {{ Add code here }} | ||
| ``` | ||
|
|
||
| ```output | ||
| {{ Add output here (remove the output block if the example doesn't have an output) }} | ||
| ``` | ||
|
|
||
| {{ Add description here }} | ||
|
|
||
| ### Example 2: {{ Add title here }} | ||
| ```powershell | ||
| {{ Add code here }} | ||
| ``` | ||
|
|
||
| ```output | ||
| {{ Add output here (remove the output block if the example doesn't have an output) }} | ||
| ``` | ||
|
|
||
| {{ Add description here }} |
Comment on lines
+17
to
+32
| Describe 'Get-AzFleetGate' { | ||
| It 'List' -skip { | ||
| { throw [System.NotImplementedException] } | Should -Not -Throw | ||
| } | ||
|
|
||
| It 'Get' -skip { | ||
| { throw [System.NotImplementedException] } | Should -Not -Throw | ||
| } | ||
|
|
||
| It 'GetViaIdentityFleet' -skip { | ||
| { throw [System.NotImplementedException] } | Should -Not -Throw | ||
| } | ||
|
|
||
| It 'GetViaIdentity' -skip { | ||
| { throw [System.NotImplementedException] } | Should -Not -Throw | ||
| } |
Comment on lines
+10
to
+12
| ## SYNOPSIS | ||
| Generates an generate run for a given auto upgrade profile. | ||
|
|
Member
|
/azp run |
Contributor
|
Azure Pipelines: Successfully started running 3 pipeline(s). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.